fix: raise gRPC client/server message limits on sbom-scanner sidecar channel#842
Conversation
|
Warning Review limit reached
More reviews will be available in 21 minutes and 4 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…channel Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
24cf85e to
4006ca4
Compare
Performance Benchmark ResultsNode-Agent Resource Usage
Dedup EffectivenessNo data available. |
Performance Benchmark ResultsNode-Agent Resource Usage
Dedup EffectivenessNo data available. |
Description
This PR resolves the issue where scanning larger images (such as
wordpress:6.0.1-php7.4) fails because the generated SBOM size exceeds the default gRPC message size limit of 4 MiB on the client-side/server-side communication channel withsbom-scannersidecar.We raise the default message size limit on both ends to 128 MiB (
128 * 1024 * 1024bytes) to safely accommodate larger SBOM payloads.This is the equivalent of kubescape/kubevuln#382 and references kubescape/kubevuln#381.
Changes
pkg/sbomscanner/v1/client.go):MaxgRPCMessageSize = 128 * 1024 * 1024.grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(MaxgRPCMessageSize), grpc.MaxCallSendMsgSize(MaxgRPCMessageSize))togrpc.NewClient.pkg/sbomscanner/v1/run.go):grpc.NewServerwithgrpc.MaxRecvMsgSize(MaxgRPCMessageSize)andgrpc.MaxSendMsgSize(MaxgRPCMessageSize).pkg/sbomscanner/v1/integration_test.goandpkg/sbomscanner/v1/server_test.go):MaxgRPCMessageSizecall and server options.