fix(xla): bound diagnostic local-task threads - #945
Merged
Conversation
inureyes
added
status:review
This was referenced Jul 27, 2026
inureyes
added a commit
that referenced
this pull request
Jul 27, 2026
The Molmo v1 reference gate created its production IREE preprocessor without first applying the diagnostics-only local-task thread configuration added in #945. `configure_diagnostic_local_task_threads` had no callers on this branch, while the Gemma3 runner already applies it, so the Molmo runner aborted before any comparison ran: xla_aux_create failed (status 13): iree/base/threading/thread_pthreads.c:159: INTERNAL; thread creation failed with 22 IREE parses its process-global flag registry when the first instance is created, so the call has to precede `load_iree` to have any effect. With this, the pinned 5.0 GB checkpoint gate completes end to end for the first time on GB10: processor stages exact, patch embedding, selected layer 14, projector, both prepared sparse-add merge stages, layer-0 KV, all-layer KV and prefill logits all pass, leaving 4 of 1,181,696 values outside tolerance at selected layer 21. Refs #870
inureyes
added a commit
that referenced
this pull request
Jul 27, 2026
The Molmo2 vision parity gate created its IREE diagnostic projector without first applying the diagnostics-only local-task thread configuration added in #945. `configure_diagnostic_local_task_threads` had no callers on this branch, so the gate aborted before any comparison ran: xla_aux_create failed (status 13): iree/base/threading/thread_pthreads.c:159: INTERNAL; thread creation failed with 22 IREE parses its process-global flag registry when the first instance is created, so the call has to precede the projector load to have any effect. This is the same defect fixed for the Molmo v1 gate. Refs #871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Runtime boundary
The mlxcel-xla library test binary intentionally does not link IREE runtime archives; final native linkage and execution are validated by the family diagnostic executable in #919 immediately after this foundation lands.
Refs #932