Skip to content

chore(core): add missing -> None return type to Tee.__init__()#35682

Closed
Debashish Mohapatra (debashish-datascience1) wants to merge 3 commits intolangchain-ai:masterfrom
debashish-datascience1:fix/my-contribution
Closed

chore(core): add missing -> None return type to Tee.__init__()#35682
Debashish Mohapatra (debashish-datascience1) wants to merge 3 commits intolangchain-ai:masterfrom
debashish-datascience1:fix/my-contribution

Conversation

@debashish-datascience1
Copy link
Copy Markdown

@debashish-datascience1 Debashish Mohapatra (debashish-datascience1) commented Mar 9, 2026

Summary

Added missing -> None return type annotation to Tee.__init__()
in langchain_core/utils/iter.py for both sync and async implementations.

@github-actions github-actions Bot added core `langchain-core` package issues & PRs external fix For PRs that implement a fix labels Mar 9, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 9, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 13 untouched benchmarks
⏩ 23 skipped benchmarks1


Comparing debashish-datascience1:fix/my-contribution (d26c0fa) with master (fcca6e2)2

Open in CodSpeed

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (7cef35b) during the generation of this report, so fcca6e2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@github-actions github-actions Bot added fix For PRs that implement a fix and removed fix For PRs that implement a fix labels Mar 9, 2026
@eyurtsev Eugene Yurtsev (eyurtsev) changed the title fix(core): add missing -> None return type to Tee.__init__() in iter … chore(core): add missing -> None return type to Tee.__init__() Apr 2, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

This PR has been automatically closed because it does not link to an approved issue.

All external contributions must reference an approved issue or discussion. Please:

  1. Find or open an issue describing the change
  2. Wait for a maintainer to approve and assign you
  3. Add Fixes #<issue_number>, Closes #<issue_number>, or Resolves #<issue_number> to your PR description and the PR will be reopened automatically

Maintainers: reopen this PR or remove the missing-issue-link label to bypass this check.

@github-actions github-actions Bot closed this Apr 2, 2026
@github-actions github-actions Bot added infra PRs made that include chores, devops, repo meta changes and removed fix For PRs that implement a fix labels Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core `langchain-core` package issues & PRs external infra PRs made that include chores, devops, repo meta changes missing-issue-link size: XS < 50 LOC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants