ci: add zizmor workflow#6
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
There was a problem hiding this comment.
LGTM — straightforward addition of a zizmor security-linting workflow with pinned SHAs, least-privilege permissions, and fork-PR safety guard.
Extended reasoning...
Overview
This PR adds a single new file, .github/workflows/zizmor.yml, a GitHub Actions workflow that runs zizmor (a static analyzer for GitHub Actions workflows) on push to main, PRs to main, merge groups, and manual dispatch. No production code or library logic is touched.
Security risks
None of concern. The workflow itself follows GitHub Actions hardening best practices: empty default permissions: {}, narrowly scoped job-level permissions (security-events: write, contents: read), persist-credentials: false on checkout, action references pinned to full commit SHAs with tag comments, and an if: guard that skips fork-PR runs so untrusted PRs cannot upload security-events results. This is a defensive addition that strengthens the repo's CI security posture.
Level of scrutiny
Low. The change is a small, self-contained, additive CI workflow with no impact on the CLI's runtime behavior. Reviewing it amounts to validating the YAML structure and the security primitives, both of which are well-formed.
Other factors
No bugs were reported by the bug hunter. There are no prior reviews or unresolved comments on the PR timeline. The workflow mirrors common patterns used for zizmor across other Langfuse repos.
Summary
Linear
Review Focus