feat(api): update API spec from langfuse/langfuse 89956fd - #1809
feat(api): update API spec from langfuse/langfuse 89956fd#1809langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
LGTM — auto-generated API client update, no bugs found.
What was reviewed: the new session_id parameter in observations get_many (client, raw_client, both sync/async) is correctly threaded through to the sessionId query param; the new isRootObservation boolean filter type addition to evaluation_rule_filter.py follows the existing discriminated-union pattern used by other filter types; docstring-only changes for metrics and comments have no behavioral effect.
Extended reasoning...
Overview
This PR is an auto-generated update of the Langfuse API client (Fern codegen) based on a spec change in the langfuse/langfuse backend repo. Changes span: docstring clarifications in comments, new documentation and examples for an isRootObservation dimension in metrics, a new optional session_id parameter added to observations.get_many (threaded through to both raw and high-level, sync and async clients), and a new boolean filter type option documented across the evaluation_rule_filter.py union types (already implemented in code via EvaluationRuleFilter_Boolean, just newly referenced in other filter classes' docstrings).
Security risks
None. This is generated client code for making authenticated HTTP requests to the Langfuse API; no new auth, crypto, or permission logic is introduced. The new session_id parameter is passed straight through to a query string param, consistent with all other existing filter parameters (e.g. user_id, trace_id).
Level of scrutiny
Low. This is boilerplate, auto-generated SDK code mirroring an upstream OpenAPI/Fern spec change. The diff is purely additive (new optional param, new docstring text, new enum-like filter type) with no control-flow changes, no removed functionality, and no edits to core request/response handling logic. This class of PR is mechanical and low-risk by nature.
Other factors
All new parameters default to None/OMIT and are backward compatible. The EvaluationRuleFilter_Boolean class already existed prior to this PR (per the diff, it wasn't newly added) — this change only adds cross-referencing documentation in sibling filter class docstrings, which is inert. No tests were affected since this is generated code with no accompanying logic changes to review against test coverage.
Greptile Summary
This generated API-spec update exposes session-ID filtering for observation listing and documents new semantic-root filtering capabilities.
session_idto synchronous and asynchronous observation clients and serializes it as thesessionIdquery parameter.isRootObservationfor metrics and evaluation-rule filters.Confidence Score: 5/5
The PR appears safe to merge, with the new observation filter correctly propagated and the documentation consistent with the generated type contracts.
The session filter remains keyword-only and is serialized under the expected query key, while the documented boolean evaluation filter matches the existing discriminated model and wire representation.
Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile
Context used: