fix: allow empty skill bundle for apps without skills#33561
Open
hikariming wants to merge 1 commit intolanggenius:refactor/skill-bundlerfrom
Open
fix: allow empty skill bundle for apps without skills#33561hikariming wants to merge 1 commit intolanggenius:refactor/skill-bundlerfrom
hikariming wants to merge 1 commit intolanggenius:refactor/skill-bundlerfrom
Conversation
When an app has no skill files in its asset tree, the publish process does not create a skill bundle. This causes SkillInitializer to fail with 'No skill bundle found' error, making the app unusable. This fix creates an empty SkillBundle when none exists, allowing apps without skills to run normally.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an app has no skill files in its asset tree, the publish process does not create a skill bundle. This causes
SkillInitializerto fail with:As a result, Chatflows without any skills cannot run at all.
Solution
Instead of raising an error when no bundle exists, create an empty
SkillBundle. This allows apps without skills to run normally while still supporting skill-based workflows when skills are present.Changes
api/core/sandbox/initializer/skill_initializer.py: Create empty bundle instead of raising errorTesting
Tested locally: