Save my sanity#640
Merged
Merged
Conversation
cmauney
approved these changes
Jun 3, 2026
cmauney
left a comment
Contributor
There was a problem hiding this comment.
It's possible to disable specific warnings on intel compiler with -diag-disable <msg#>. Maybe cleaner if there is only 1-2 messages repeated.
Yurlungur
approved these changes
Jun 3, 2026
Yurlungur
left a comment
Collaborator
There was a problem hiding this comment.
no objections and no it doesn't need a changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
On one of the systems I'm building on, I'm using an intel compiler, and for
Debugbuilds there are literal thousands of lines of compiler warnings related to tautological comparisons for nan and inf checks. This is because even in Debug mode, intel will enable-ffast-mathwhich assumes your code will not produce nans/infs.This adds a compile flag to disable some piece of this in Debug Intel builds.
Not sure if this needs a changelog
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: