Skip to content

Save my sanity#640

Merged
Yurlungur merged 1 commit into
mainfrom
dempsey/intel
Jun 3, 2026
Merged

Save my sanity#640
Yurlungur merged 1 commit into
mainfrom
dempsey/intel

Conversation

@adamdempsey90

Copy link
Copy Markdown
Collaborator

PR Summary

On one of the systems I'm building on, I'm using an intel compiler, and for Debug builds there are literal thousands of lines of compiler warnings related to tautological comparisons for nan and inf checks. This is because even in Debug mode, intel will enable -ffast-math which assumes your code will not produce nans/infs.

This adds a compile flag to disable some piece of this in Debug Intel builds.

Not sure if this needs a changelog

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file.
  • LANL employees: make sure tests pass both on the github CI and on the Darwin CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.
  • Move the changes in the CHANGELOG.md file under a new header for the new release, and reset the categories.
  • Maintainers: ensure spackages are up to date:
    • LANL-internal team, update XCAP spackages
    • Current maintainer of upstream spackages, submit MR to spack

@cmauney cmauney left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible to disable specific warnings on intel compiler with -diag-disable <msg#>. Maybe cleaner if there is only 1-2 messages repeated.

@Yurlungur Yurlungur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no objections and no it doesn't need a changelog

@Yurlungur Yurlungur merged commit 9953e71 into main Jun 3, 2026
9 checks passed
@Yurlungur Yurlungur deleted the dempsey/intel branch June 3, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants