sesame2spiner refactor#641
Conversation
…es. Modify cmake so that we build a library.
|
Evidently there's some cmake stuff left to figure it when things like spiner are not requested or when not in submodule mode maybe |
Co-authored-by: Adam M. Dempsey <adamdemps@gmail.com>
| # Check both HDF5_C_COMPILER_NO_INTERROGATE and HDF5_C_COMPILER_EXECUTABLE_NO_INTERROGATE | ||
| # as the variable name may differ across CMake/HDF5 versions | ||
| if(NOT ((HDF5_C_COMPILER_NO_INTERROGATE OR HDF5_C_COMPILER_EXECUTABLE_NO_INTERROGATE) AND SINGULARITY_FORCE_SUBMODULE_MODE)) | ||
|
|
There was a problem hiding this comment.
this might be the cray hdf5 issue I've seen previously
| PRIVATE | ||
| sesame2spiner-lib |
There was a problem hiding this comment.
I'm not totally sure on if this should be private or public
There was a problem hiding this comment.
This file is not included anywhere I think?
| $<$<AND:$<CXX_COMPILER_ID:GNU>,$<COMPILE_LANGUAGE:CXX>>:-Wno-class-memaccess> | ||
| # Intel compilers enable -ffast-math even in Debug builds. This disables finite-math-only in | ||
| # Debug builds to allow NaN/Inf checks without pages of warnings | ||
| # Disable finite-math-only in Debug builds to allow NaN/Inf checks (Intel compilers) |
There was a problem hiding this comment.
Accidental change
Okay, all tests are passing now so I think this is ready for review |
|
Is there an expected lifecycle for the forwarding headers? If so, how should we communicate to users that the forwarding headers are in place? Our changelog mostly just points users to MR's, but maybe in this case something more concrete about changes they should make? Issue a warning if the forwarding header is used? |
I see a few options:
I don't really think people outside of us are going to act on the warnings, so I'm leaning towards option 2. |
PR Summary
This does some refactoring on the code base to build
sesame2spineras a library thatsingularity-eoslinks in while maintaining the executablesesame2spiner.sesame2spinerwas linking insingularity-eosfor some things, so I have moved those shared headers into a new library calledsingularity-utils. For backwards compatibility in downstream codes, I have replaced the headers lost insingularity-eos/basewith forwarding headers tosingularity-utils. I have updated the includes insingularity-eosproper with the new ones.If I did everything correctly, nothing should've changed. So my plan is to have this MR merged, then follow up with adding the functions to
sesame2spinerthe library to process tables without reading a file.PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: