Skip to content

[13.x] Add minProperties and maxProperties to JsonSchema ObjectType#60264

Closed
hamdyelbatal122 wants to merge 1 commit into
laravel:13.xfrom
hamdyelbatal122:json-schema-object-min-max-properties
Closed

[13.x] Add minProperties and maxProperties to JsonSchema ObjectType#60264
hamdyelbatal122 wants to merge 1 commit into
laravel:13.xfrom
hamdyelbatal122:json-schema-object-min-max-properties

Conversation

@hamdyelbatal122
Copy link
Copy Markdown

ArrayType already has min() / max() for minItems and maxItems. ObjectType was missing the same for property counts.

Adds min() and max() on ObjectType, same pattern as ArrayType.

@taylorotwell
Copy link
Copy Markdown
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants