[13.x] Add lineUnless and linesUnless to notification messages#60267
Closed
LucasCavalheri wants to merge 1 commit into
Closed
[13.x] Add lineUnless and linesUnless to notification messages#60267LucasCavalheri wants to merge 1 commit into
LucasCavalheri wants to merge 1 commit into
Conversation
Member
|
Thanks for your pull request to Laravel! Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include. If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
lineUnlessandlinesUnlessmethods to notification messages viaSimpleMessage.These methods provide the inverse conditional behavior of the existing
lineIfandlinesIfhelpers:This keeps the API consistent with Laravel's broader
when/unlessconventions and improves readability when the negative condition is the intended flow.Motivation
SimpleMessagealready provides conditional helpers throughlineIfandlinesIf, but currently lacks theirunlesscounterparts.Without these methods, developers must negate conditions manually:
Adding dedicated
unlessvariants improves expressiveness and keeps the notification API symmetrical and consistent with other framework patterns.Changes
lineUnless()toSimpleMessagelinesUnless()toSimpleMessageTests
Added the following tests to
NotificationMailMessageTest:testLineUnlesstestLinesUnlessVerified with:
Backward Compatibility
This change is fully backward compatible and only introduces additional convenience methods without altering existing behavior.