[12.x] Throw ManagedQueueNotFoundException when a managed queue is missing#60276
Open
kieranbrown wants to merge 3 commits into
Open
[12.x] Throw ManagedQueueNotFoundException when a managed queue is missing#60276kieranbrown wants to merge 3 commits into
kieranbrown wants to merge 3 commits into
Conversation
…ed queues Wraps AWS.SimpleQueueService.NonExistentQueue errors at the SQS client handler stack so every managed queue operation surfaces a clear message including the queue name, instead of the vague AWS error. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… test Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #60275.
When a managed queue doesn't exist, the underlying AWS SDK error is vague and doesn't include the queue name, making it hard to debug.
This PR registers an SQS client middleware (in
Foundation\Cloud\QueueConnector) that interceptsAWS.SimpleQueueService.NonExistentQueueerrors and rethrows them as a newManagedQueueNotFoundExceptionwith a clear message:The original
AwsExceptionis preserved as$previous. Because the middleware sits at the handler-stack level, every SQS operation (push, pop, size, clear, batch, etc.) is covered without wrapping individual queue methods.Scoped to managed queues only — plain
SqsQueueusers are unaffected.🤖 Generated with Claude Code