feat: interactive upgrade prompt for bare lark-cli#1498
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughAdds an interactive upgrade prompt to the bare ChangesRoot Interactive Upgrade Prompt
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
the
size/L
🚀 PR Preview Install Guide🧰 CLI updatenpm i -g https://pkg.pr.new/larksuite/cli/@larksuite/cli@876c35c78c30125a9c0d24a24f18b265d8136329🧩 Skill updatenpx skills add larksuite/cli#feat/root-interactive-upgrade -y -g |
dc-bytedance
force-pushed
the
feat/root-interactive-upgrade
branch
from
c3d6bea to
d08f6b1
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cmd/root_upgrade_test.go (1)
101-108: ⚡ Quick winUse
cmdutil.TestFactory(t, config)instead of manualcmdutil.Factoryconstruction in tests.At Line 101 and Line 131, direct
&cmdutil.Factory{...}setup can drift from shared defaults and test harness behavior.As per coding guidelines,
**/*_test.go: “Usecmdutil.TestFactory(t, config)for test factories.”Also applies to: 131-133
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cmd/root_upgrade_test.go` around lines 101 - 108, Replace the manual construction of cmdutil.Factory using &cmdutil.Factory{IOStreams: &cmdutil.IOStreams{...}} at both locations (around line 101 and line 131) with the cmdutil.TestFactory(t, config) helper function instead. This ensures the test factories use shared defaults and test harness behavior consistently across all tests, preventing drift from the intended test setup patterns.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cmd/root_upgrade_test.go`:
- Around line 101-108: Replace the manual construction of cmdutil.Factory using
&cmdutil.Factory{IOStreams: &cmdutil.IOStreams{...}} at both locations (around
line 101 and line 131) with the cmdutil.TestFactory(t, config) helper function
instead. This ensures the test factories use shared defaults and test harness
behavior consistently across all tests, preventing drift from the intended test
setup patterns.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5846f316-39d0-45df-a89a-7006e14656d2
📒 Files selected for processing (5)
cmd/build.gocmd/root_upgrade.gocmd/root_upgrade_test.gointernal/cmdutil/iostreams.gointernal/cmdutil/iostreams_test.go
dc-bytedance
force-pushed
the
feat/root-interactive-upgrade
branch
from
d08f6b1 to
3e5a172
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1498 +/- ##
==========================================
+ Coverage 73.43% 73.49% +0.05%
==========================================
Files 753 783 +30
Lines 70182 74593 +4411
==========================================
+ Hits 51540 54822 +3282
- Misses 14829 15674 +845
- Partials 3813 4097 +284 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cmd/root_upgrade.go`:
- Around line 22-26: Add test cases to cover the uncovered behavior branches
introduced in this PR. First, create a test for the runRootUpgrade function that
verifies the dispatch logic correctly finds and executes the "update" command
when it exists with a valid RunE function. Second, add a test case for the inner
== nil guard condition at line 82 to ensure the code handles the nil scenario
correctly. These tests should explicitly verify the expected behavior of each
branch to satisfy the requirement that every behavior change needs an
accompanying test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 77eb891f-2862-473b-9c1d-5c78b671496e
📒 Files selected for processing (5)
cmd/build.gocmd/root_upgrade.gocmd/root_upgrade_test.gointernal/cmdutil/iostreams.gointernal/cmdutil/iostreams_test.go
🚧 Files skipped from review as they are similar to previous changes (4)
- cmd/build.go
- internal/cmdutil/iostreams.go
- cmd/root_upgrade_test.go
- internal/cmdutil/iostreams_test.go
When a newer version is cached and stdin, stdout and stderr are all a TTY, bare `lark-cli` (no subcommand) prompts `Upgrade now? [y/N]` on stderr: `y` runs the existing `lark-cli update`, `n`/Enter/EOF skips, then the usual help prints. Only the bare root command triggers it; other commands, `lark-cli update`, and the JSON `_notice` channel are unchanged. Detection and throttle reuse update.CheckCached, with no new persisted state. - add cmd/root_upgrade.go (offerRootUpgrade, runRootUpgrade, readYes, isBareRootInvocation, installRootUpgradePrompt) - add OutIsTerminal to cmdutil.IOStreams; reuse existing StderrIsTerminal - wire installRootUpgradePrompt into cmd/build.go - add unit tests for the prompt logic and the new IOStreams fields
dc-bytedance
force-pushed
the
feat/root-interactive-upgrade
branch
from
3e5a172 to
876c35c
Compare
PR Quality SummaryThe semantic review system could not produce a fully trusted result. This is not reported as a code defect. System status
|
1 participant
Summary
lark-cli already detects new versions, but the upgrade info is only surfaced via the JSON
_notice.updatefield, which is consumed by AI agents — a human typing commands in a terminal never sees it. This PR adds an interactive upgrade prompt for the barelark-cliinvocation (no subcommand): when a newer version is cached and the session is a real interactive terminal, it asksUpgrade now? [y/N]on stderr —yruns the existinglark-cli update,n/Enter/EOF skips — then prints the usual help. Only the bare root command triggers it; all other commands,lark-cli updateitself, and the JSON_noticechannel are unchanged.Changes
cmd/root_upgrade.go:offerRootUpgrade(three-stream TTY gate + cached-version check +[y/N]prompt),runRootUpgrade(reuses the registeredupdatesubcommand'sRunE),readYes,isBareRootInvocation, andinstallRootUpgradePromptOutIsTerminaltocmdutil.IOStreamsand reuse the existingStderrIsTerminalininternal/cmdutil/iostreams.go; the interactive gate requires stdin && stdout && stderr to all be a TTYinstallRootUpgradePrompt(f, rootCmd)after the unknown-subcommand guard incmd/build.goupdate.CheckCached;internal/update/update.gois unchanged — no new persisted statecmd/root_upgrade_test.goandinternal/cmdutil/iostreams_test.goTest Plan
make unit-testpassed_noticeunchanged, pipedynot consumed) are covered by acceptance-reviewer against a real release binary and by host-level E2E. skillave N/A (no shortcut/skill/meta change)lark-cli(non-TTY, cached newer version) prints help, exits 0, noUpgrade now?line;update-state.jsonbyte-identical before/after (no state written); JSON_notice.updateunchanged on subcommandsRelated Issues
N/A
Summary by CodeRabbit
Release Notes