fix: deflake hooks-ordering contract test#563
Draft
beekld wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes flaky contract tests
hooks/evaluation/executes beforeEvaluation hooks in registration orderand the correspondingafterEvaluationreverse-order test, which had been intermittently red on CI.Root cause:
ContractTestHook::PostCallbackwas firing the harness notifications as fire-and-forget async chains (resolve -> connect -> write). The SDK invokes hooks sequentially, but the three async POSTs then race on the wire, so the harness can receive them in any order.Fix: send each callback synchronously via the boost::beast sync HTTP API. The sync path uses blocking syscalls rather than the reactor, so there is no deadlock on the single-thread io_context, and each POST completes before the next hook's call starts.
Local repro on macOS over loopback: 2/50 fails before, 0/100 after.