Skip to content

chore: adding vue client sdk wrapper#1435

Open
joker23 wants to merge 2 commits into
mainfrom
skz/sdk-2194/migrate-vue-sdk-client-wrapper
Open

chore: adding vue client sdk wrapper#1435
joker23 wants to merge 2 commits into
mainfrom
skz/sdk-2194/migrate-vue-sdk-client-wrapper

Conversation

@joker23

@joker23 joker23 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Additional changes:

  • modified tsconfig.json to match the rest of the monorepo

Note

Low Risk
New package surface and thin delegation to the existing JS client SDK; no auth or server paths, with behavior covered by unit tests.

Overview
Replaces the Vue package scaffold with a working createClient factory that wraps @launchdarkly/js-client-sdk, sets default wrapperName / wrapperVersion, and adds Vue-oriented lifecycle APIs (getInitializationState, isReady, onInitializationStatusChange with replay for late subscribers, onContextChange after successful start / identify).

Exports LDVueClient, LDVueInstance, and LDVueProviderOptions types (provider/composables still TODO). Package now depends on the workspace JS client SDK, runs Jest without passWithNoTests, and adds test tooling; tsconfig.json is updated to match other SDK packages (ES2020, bundler resolution).

Reviewed by Cursor Bugbot for commit 2ac41fc. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@joker23

joker23 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit bc71f02. Configure here.

@joker23 joker23 marked this pull request as ready for review June 9, 2026 15:59
@joker23 joker23 requested a review from a team as a code owner June 9, 2026 15:59

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Additional changes:
- modified tsconfig.json to match the rest of the monorepo
@joker23 joker23 force-pushed the skz/sdk-2194/migrate-vue-sdk-client-wrapper branch from bc71f02 to 93de4ba Compare June 15, 2026 21:23
cursor[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant