Skip to content

feat!: release @launchdarkly/openfeature-js-server-common#1754

Open
joker23 wants to merge 2 commits into
mainfrom
skz/sdk-2213/openfeature-migration-publish-server-common
Open

feat!: release @launchdarkly/openfeature-js-server-common#1754
joker23 wants to merge 2 commits into
mainfrom
skz/sdk-2213/openfeature-migration-publish-server-common

Conversation

@joker23

@joker23 joker23 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

This PR will release the openfeature-js-server-common package to npm at version 1. This package is not meant to be used directly, but rather as a shared package that is used by sdks. All this to say, publishing this package is effectively a NOOP.

We just want to make sure this package publishes before we publish openfeature-node-server


Note

Low Risk
Changes are release automation, docs, and dev tooling; no application/runtime logic in the diff for a package not intended for direct consumption.

Overview
Prepares @launchdarkly/openfeature-js-server-common for its first stable npm release at 1.0.0, moving off prerelease (release-as / manifest 0.1.3 → 1.0.0) so it can publish before openfeature-node-server.

Adds dedicated CI (openfeature-server-common.yaml, Node 20/22) and wires the package into release-please (manual dispatch option, release output, and a release-openfeature-server-common full-release job). Root README and CONTRIBUTING now list the package with npm/CI/issue links; the package README drops the pre-release caution and points CI/docs badges at the new workflow and GitHub Pages API docs.

In the package itself: typedoc.json for API docs, ESLint 9 flat-config style devDependencies (replacing ESLint 8 / prettier-eslint stack), and a simplified lint script.

Reviewed by Cursor Bugbot for commit 6a71fad. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@joker23 joker23 marked this pull request as ready for review June 17, 2026 21:58
@joker23 joker23 requested a review from a team as a code owner June 17, 2026 21:58

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 2 additional findings in Devin Review.

Open in Devin Review

"packages/shared/akamai-edgeworker-sdk": "2.0.23",
"packages/shared/common": "2.25.1",
"packages/shared/openfeature-server-common": "0.1.3",
"packages/shared/openfeature-server-common": "1.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Release-please manifest prematurely set to 1.0.0 will prevent automated 1.0.0 release

The .release-please-manifest.json was changed from "0.1.3" to "1.0.0" for packages/shared/openfeature-server-common, but this version has not actually been released — the package.json still says 0.1.3, the CHANGELOG only goes up to 0.1.3, and the latest git tag is openfeature-js-server-common-v0.1.3. The manifest records the last released version. Combined with "release-as": "1.0.0" in release-please-config.json:398, release-please will see the manifest already at 1.0.0 and believe this version was already released, so it will not create a release PR for 1.0.0. The package will remain stuck at 0.1.3 in the automated pipeline. The manifest should stay at "0.1.3" — release-please will then see the gap and use the release-as directive to produce a 1.0.0 release PR.

Suggested change
"packages/shared/openfeature-server-common": "1.0.0",
"packages/shared/openfeature-server-common": "0.1.3",
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant