Skip to content

feat!: release @launchdarkly/client-testing-plugin#1755

Open
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-1997/client-test-data
Open

feat!: release @launchdarkly/client-testing-plugin#1755
joker23 wants to merge 1 commit into
mainfrom
skz/sdk-1997/client-test-data

Conversation

@joker23

@joker23 joker23 commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Releasing @launchdarkly/client-testing-plugin as 1.0.0


Note

Low Risk
Release and documentation-only changes with no runtime or SDK logic modified in this diff.

Overview
Promotes @launchdarkly/client-testing-plugin from pre-release to stable 1.0.0 via release-please: the manifest bumps 0.1.11.0.0, and the package entry switches from prerelease/minor-bump rules to release-as: 1.0.0.

The README drops the pre-release caution (no backwards-compat guarantees, pin minor, review changelog) and presents the plugin as a normal testing dependency. Dependent example wiring (e.g. React testing example) continues to be updated through existing extra-files config.

Reviewed by Cursor Bugbot for commit c8c0d14. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26365 bytes
Compressed size limit: 29000
Uncompressed size: 129044 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 38739 bytes
Compressed size limit: 39000
Uncompressed size: 212244 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31978 bytes
Compressed size limit: 34000
Uncompressed size: 114243 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179579 bytes
Compressed size limit: 200000
Uncompressed size: 831422 bytes

@joker23 joker23 marked this pull request as ready for review June 17, 2026 21:56
@joker23 joker23 requested a review from a team as a code owner June 17, 2026 21:56

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Open in Devin Review

"packages/telemetry/node-server-sdk-otel": "1.3.17",
"packages/tooling/jest": "1.0.22",
"packages/tooling/client-testing-plugin": "0.1.1",
"packages/tooling/client-testing-plugin": "1.0.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Manifest version updated to 1.0.0 without corresponding package.json update, causing version desync

The .release-please-manifest.json is updated from 0.1.1 to 1.0.0 for client-testing-plugin, but the actual packages/tooling/client-testing-plugin/package.json:3 still has "version": "0.1.1". Every other package in the monorepo (29 packages) has its manifest version in sync with its package.json version — this is the only mismatch.

The manifest is the source of truth for release-please to know the "current released version." With the manifest at 1.0.0 and release-as: "1.0.0" in the config (release-please-config.json:344), release-please will consider 1.0.0 as already released and won't generate a release PR to update the package.json. The next release-please PR would bump to 1.0.1 or higher, meaning the package.json jumps directly from 0.1.1 to a post-1.0.0 version — the actual 1.0.0 release with the correct package.json version would never be published.

Fix options

Either: (a) remove the manifest update and leave it at 0.1.1 so release-please handles the 1.0.0 bump via the release-as directive, or (b) also update package.json to 1.0.0 and add a CHANGELOG entry for 1.0.0 to complete the manual release.

Prompt for agents
The .release-please-manifest.json has been updated to 1.0.0 for client-testing-plugin, but the package.json at packages/tooling/client-testing-plugin/package.json still has version 0.1.1. This is the only package in the entire monorepo with a manifest/package.json version mismatch.

The manifest is release-please's source of truth for the current released version. With manifest at 1.0.0 and release-as: 1.0.0 in release-please-config.json, release-please will think 1.0.0 is already released and won't create a release PR to update the package.json. The package would jump from 0.1.1 directly to 1.0.1+, skipping the intended 1.0.0 release.

Two possible fixes:

Option A (let release-please handle the bump): Revert the manifest change in .release-please-manifest.json back to 0.1.1. The release-as: 1.0.0 directive in release-please-config.json will tell release-please to create a release PR that bumps both the manifest and package.json to 1.0.0.

Option B (manual release): Also update packages/tooling/client-testing-plugin/package.json version to 1.0.0 and add a 1.0.0 entry in packages/tooling/client-testing-plugin/CHANGELOG.md.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant