Open
Conversation
Widen http gem constraint from < 6.0.0 to < 7.0.0 and update HTTP client usage for v6 compatibility: use symbol keys and double-splat for HTTP::Client.new, pass keyword args to .timeout() and .request(). fixes #373
keelerm84
changed the title
jsonbailey
reviewed
Mar 26, 2026
| end | ||
| HTTP::Client.new(http_client_options) | ||
| .timeout({ | ||
| HTTP::Client.new(**http_client_options) |
Contributor
There was a problem hiding this comment.
Did we need to do the same guards we did for event source?
jsonbailey
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widen http gem constraint from < 6.0.0 to < 7.0.0 and update HTTP
client usage for v6 compatibility: use symbol keys and double-splat
for HTTP::Client.new, pass keyword args to .timeout() and .request().
fixes #373
Note
Medium Risk
Updates core HTTP client construction and request invocation to match
httpgem v6 keyword-arg APIs; mistakes here could break network I/O for feature polling and event delivery. Dependency range widening also increases compatibility surface area across supportedhttpversions.Overview
Expands supported
httpgem versions from< 6to< 7(including contract tests) and updates runtime dependencies accordingly.Adjusts internal HTTP usage for
httpv6 compatibility: uses symbol-keyed options with**when buildingHTTP::Client, switches.timeoutand.requestcalls to keyword args, and bumpsld-eventsourceto2.6.0.Written by Cursor Bugbot for commit a8ab91c. This will update automatically on new commits. Configure here.