fix: add duration and tags missing#1049
Conversation
Signed-off-by: Navneet Anand <itworksnavneet@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates video metadata by adding tags and duration fields across several files and correcting a typo in the duration key for the 'publish-design' video. The review feedback identifies a potential UI issue where the 'MM:SS' duration format will be incorrectly displayed with a hardcoded ' min' suffix (e.g., '0:16 min') due to existing template logic. It is recommended to either provide the duration as a numeric value in minutes or update the site templates to handle the time format correctly.
| autoplay: true # optional | ||
| loop: true #optional | ||
| tags: [kanvas] | ||
| duration: "0:16" |
There was a problem hiding this comment.
The duration format 0:16 (MM:SS) will be displayed as 0:16 min in the UI because the template in layouts/partials/video-landing-page.html (lines 89 and 140) appends a hardcoded min suffix. This results in a confusing label for users. Since this PR aims to normalize metadata, consider either providing the duration as a numeric value in minutes or updating the template to remove the hardcoded suffix when a MM:SS format is used.
| autoplay: true # optional | ||
| loop: true #optional | ||
| tags: [meshery] | ||
| duration: "0:53" |
There was a problem hiding this comment.
The duration format 0:53 (MM:SS) will be displayed as 0:53 min due to the hardcoded min suffix in the video landing page template. This is inconsistent with the time format provided. Consider adjusting the metadata or the template to ensure the duration is displayed correctly.
| formats: [video] | ||
| tags: [catalog, designs, publishing] | ||
| duraiton: 0:39 | ||
| duration: "0:39" |
There was a problem hiding this comment.
The duration format 0:39 (MM:SS) will be displayed as 0:39 min due to the hardcoded min suffix in the video landing page template. This is inconsistent with the time format provided. Consider adjusting the metadata or the template to ensure the duration is displayed correctly.
|
🚀 Preview deployment: https://layer5io.github.io/docs/pr-preview/pr-1049/
|
1 participant
Notes for Reviewers
This PR fixes #1048 by normalizing video metadata so duration/tags render consistently across cards.
Adds/updates duration and tags for Publishing Designs, Meshery Playground Teaser, and Birth of Kanvas Logo entries.
2026-05-16.14-54-28.mp4
Signed commits