Skip to content

docs(kanvas): update hierarchical relationship definitions, add visual example and added evaluation engine description #1137

Open
YASHMAHAKAL wants to merge 1 commit into
layer5io:masterfrom
YASHMAHAKAL:evaluation-engine-docs
Open

docs(kanvas): update hierarchical relationship definitions, add visual example and added evaluation engine description #1137
YASHMAHAKAL wants to merge 1 commit into
layer5io:masterfrom
YASHMAHAKAL:evaluation-engine-docs

Conversation

@YASHMAHAKAL

@YASHMAHAKAL YASHMAHAKAL commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Description:
Added a detailed explanation for the Hierarchical-Wallet relationship and evaluation engine description. Replaced incorrect and static SVG diagrams with accurate, animated GIFs for both the Wallet and Inventory relationships to better demonstrate the UI interactions in Kanvas.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kanvas documentation by renaming and refining the hierarchical relationship subtypes to "Hierarchical-Parent-Inventory" and "Hierarchical-Parent-Wallet", complete with updated descriptions and illustrative GIFs. Additionally, it introduces a new section to the relationship evaluation page explaining the core responsibilities of the evaluation engine. Feedback was provided to correct inconsistent indentation and fix a capitalization typo ("wallet" to "Wallet") in the newly added description.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

**ii. Hierarchical-Parent-Wallet**

A parent-child relationship implies that the parent component must be present or established before the child component can be created. For instance, in Kubernetes, a 'Namespace' can serve as a parent to 'Pods' within that namespace. Therefore, the namespace must be created beforehand for pods to be deployed within it. Here's an example of a Hierarchical-Parent relationship
This is a relationship between components where one component is directly attached to a host component, acting as an integrated inventory item. This implies a reverse configuration dependency: the configuration settings of the parent component are mutated or updated to synchronize with the attached child component. For example, attaching a sidecar container or a WebAssembly (WASM) filter to a workload will automatically modify the host workload's configuration to include the new item. On the canvas, these attached items are visualized as a numeric design inventory badge on the parent component rather than as standalone shapes. Here's an example of a Hierarchical-Parent-wallet relationship

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The paragraph indentation is inconsistent with the first list item (which uses 2 spaces of indentation on line 97), and "Hierarchical-Parent-wallet" uses a lowercase "w" for "wallet" which is inconsistent with the heading on line 101. Please adjust the indentation to 2 spaces and capitalize "Wallet".

Suggested change
This is a relationship between components where one component is directly attached to a host component, acting as an integrated inventory item. This implies a reverse configuration dependency: the configuration settings of the parent component are mutated or updated to synchronize with the attached child component. For example, attaching a sidecar container or a WebAssembly (WASM) filter to a workload will automatically modify the host workload's configuration to include the new item. On the canvas, these attached items are visualized as a numeric design inventory badge on the parent component rather than as standalone shapes. Here's an example of a Hierarchical-Parent-wallet relationship
This is a relationship between components where one component is directly attached to a host component, acting as an integrated inventory item. This implies a reverse configuration dependency: the configuration settings of the parent component are mutated or updated to synchronize with the attached child component. For example, attaching a sidecar container or a WebAssembly (WASM) filter to a workload will automatically modify the host workload's configuration to include the new item. On the canvas, these attached items are visualized as a numeric design inventory badge on the parent component rather than as standalone shapes. Here's an example of a Hierarchical-Parent-Wallet relationship
References
  1. Use hyphens for compound adjectives modifying a noun (e.g., 'Hierarchical-Parent-Wallet relationship').

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview deployment: https://docs.layer5.io/pr-preview/pr-1137/

Note: Preview may take a moment (GitHub Pages deployment in progress). Please wait and refresh. Track deployment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants