Fix(sistent): Added Table component documentation#7692
Conversation
|
| - Hard-code hex colour values — always use Sistent theme tokens. | ||
| - Rely on colour alone to convey row status; supplement with text or icons. | ||
|
|
||
| ## Row Density |
|
|
||
| The **Table** component organizes information into rows and columns, making it easy for users to read, compare, and analyze data. Use a Table when displaying multiple records with consistent attributes such as services, users, or deployments, when users need to compare values across rows or columns, or when data needs sorting, filtering, or pagination for large data sets. | ||
|
|
||
| ## Anatomy |
|
@rishiraj38, I have addressed all the feedback. |
9f9988f to
a839e49
Compare
There was a problem hiding this comment.
@rishiraj38, I have addressed all the feedback.
Preview: https://layer5.io/pr-preview/pr-7692/projects/sistent/components/table/code
|
@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
@rishiraj38, I have addressed your comment. |
| --- | ||
|
|
||
| import { useState } from "react"; | ||
| import { Table, TableBody, TableCell, TableContainer, TableHead, TableRow, TableSortLabel, Paper, Checkbox, Toolbar, Typography } from "@sistent/sistent"; |
There was a problem hiding this comment.
Instead of this please use ResponsiveDataTable which is available in sistent
There was a problem hiding this comment.
Hi @Rajesh-Nagarajan-11, I have been looking into this, and while ResponsiveDataTable is in the compiled bundle for @sistent/sistent, it doesn't seem to be exported in the index.d.ts definitions. I also could not find any existing usage of it within the layer5 src directory to use as a reference. Could you point me to an example of where this is currently implemented?
There was a problem hiding this comment.
Thank you @rishiraj38, I will look into it.
There was a problem hiding this comment.
@Rajesh-Nagarajan-11, @rishiraj38, I have updated all four table demos to use ResponsiveDataTable from @sistent/sistent.
1a7608f to
da58a9a
Compare
|
@saurabhraghuvanshii, please take a look. |
|
@Rajesh-Nagarajan-11 and @rishiraj38, gentle ping |
rishiraj38
left a comment
There was a problem hiding this comment.
@kanishksingh23 Please don't use maintainer names use something generic and also selectable Rows table are not working
|
@Rajesh-Nagarajan-11 One confusion here we have used Responsive DataTables here then do we need still need this issue #7681 |
|
Yep we can close that issue @rishiraj38 |
513ca26 to
7149e0e
Compare
@rishiraj38, names are fixed, and I tried selectable rows also, but still it's not clickable. |
|
@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
rishiraj38
left a comment
There was a problem hiding this comment.
Please try applying those fixes and let’s see if they resolve the issue.
| if (!mounted) return null; | ||
| return ( | ||
| <ResponsiveDataTable | ||
| columns={columns} |
There was a problem hiding this comment.
| columns={columns} | |
| columns={tableCols} |
| ["Charlie", "development"], | ||
| ], []); | ||
| const [tableCols, updateCols] = useState(columns); | ||
| const [columnVisibility, setColumnVisibility] = useState({}); |
There was a problem hiding this comment.
It may need default visibility values for the columns, otherwise the selectable table behavior might not work correctly.
84b0ba5 to
b303f41
Compare
6a96841 to
b042e0d
Compare
|
@kanishksingh23, are you available to undertake this task, or should it be reassigned? |
I am working on it. |
6d0f3c6 to
b042e0d
Compare
|
@kanishksingh23 Please open a new PR for this. |
Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>





Description
Adds documentation for the Table component to the Sistent components page.
This PR fixes #7607
Changes
index.mdx— Overview, anatomy, variants, and accessibility guidanceguidance.mdx— Best practices and do's/don'ts for using the Table componentcode.mdx— Code examples for Basic, Sortable, Selectable Rows, and Paginated tablesNotes for Reviewers
Documentation follows the same structure as the Button component.
Preview deployment will show the rendered pages at
/projects/sistent/components/table.Signed commits