Skip to content

Fix(sistent): Added Table component documentation#7692

Closed
kanishksingh23 wants to merge 2 commits into
layer5io:masterfrom
kanishksingh23:fix/sistent-table-docs
Closed

Fix(sistent): Added Table component documentation#7692
kanishksingh23 wants to merge 2 commits into
layer5io:masterfrom
kanishksingh23:fix/sistent-table-docs

Conversation

@kanishksingh23
Copy link
Copy Markdown
Contributor

Description
Adds documentation for the Table component to the Sistent components page.

This PR fixes #7607

Changes

  • Added index.mdx — Overview, anatomy, variants, and accessibility guidance
  • Added guidance.mdx — Best practices and do's/don'ts for using the Table component
  • Added code.mdx — Code examples for Basic, Sortable, Selectable Rows, and Paginated tables

Notes for Reviewers
Documentation follows the same structure as the Button component.
Preview deployment will show the rendered pages at /projects/sistent/components/table.

Signed commits

  • Yes, I signed my commits.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

PR Preview Action v1.6.3
Preview removed because the pull request was closed.
2026-05-16 12:51 UTC

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix all these

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the code part ?

Image

- Hard-code hex colour values — always use Sistent theme tokens.
- Rely on colour alone to convey row status; supplement with text or icons.

## Row Density
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this

Image


The **Table** component organizes information into rows and columns, making it easy for users to read, compare, and analyze data. Use a Table when displaying multiple records with consistent attributes such as services, users, or deployments, when users need to compare values across rows or columns, or when data needs sorting, filtering, or pagination for large data sets.

## Anatomy
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix here also

Image

@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@rishiraj38, I have addressed all the feedback.

@kanishksingh23 kanishksingh23 force-pushed the fix/sistent-table-docs branch 2 times, most recently from 9f9988f to a839e49 Compare May 2, 2026 13:33
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’ve added the code part but where’s the preview or example? Please check the other component’s code part and fix it.

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a better example of paginated table code preview for your reference.

Image

@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@rishiraj38, I have addressed your comment.

---

import { useState } from "react";
import { Table, TableBody, TableCell, TableContainer, TableHead, TableRow, TableSortLabel, Paper, Checkbox, Toolbar, Typography } from "@sistent/sistent";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this please use ResponsiveDataTable which is available in sistent

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Rajesh-Nagarajan-11, I have been looking into this, and while ResponsiveDataTable is in the compiled bundle for @sistent/sistent, it doesn't seem to be exported in the index.d.ts definitions. I also could not find any existing usage of it within the layer5 src directory to use as a reference. Could you point me to an example of where this is currently implemented?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanishksingh23 It’s extensively used in meshery.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rishiraj38, I will look into it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajesh-Nagarajan-11, @rishiraj38, I have updated all four table demos to use ResponsiveDataTable from @sistent/sistent.

@kanishksingh23 kanishksingh23 force-pushed the fix/sistent-table-docs branch 2 times, most recently from 1a7608f to da58a9a Compare May 6, 2026 07:02
@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@saurabhraghuvanshii, please take a look.

@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@Rajesh-Nagarajan-11 and @rishiraj38, gentle ping

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kanishksingh23 Please don't use maintainer names use something generic and also selectable Rows table are not working

@rishiraj38
Copy link
Copy Markdown
Member

rishiraj38 commented May 7, 2026

@Rajesh-Nagarajan-11 One confusion here we have used Responsive DataTables here then do we need still need this issue #7681

@Rajesh-Nagarajan-11
Copy link
Copy Markdown
Member

Yep we can close that issue @rishiraj38

@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@kanishksingh23 Please don't use maintainer names use something generic and also selectable Rows table are not working

@rishiraj38, names are fixed, and I tried selectable rows also, but still it's not clickable.

@Bhumikagarggg
Copy link
Copy Markdown
Contributor

@kanishksingh23 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Copy link
Copy Markdown
Member

@rishiraj38 rishiraj38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try applying those fixes and let’s see if they resolve the issue.

if (!mounted) return null;
return (
<ResponsiveDataTable
columns={columns}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
columns={columns}
columns={tableCols}

["Charlie", "development"],
], []);
const [tableCols, updateCols] = useState(columns);
const [columnVisibility, setColumnVisibility] = useState({});
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may need default visibility values for the columns, otherwise the selectable table behavior might not work correctly.

@rishiraj38
Copy link
Copy Markdown
Member

@kanishksingh23, are you available to undertake this task, or should it be reassigned?

@kanishksingh23
Copy link
Copy Markdown
Contributor Author

@kanishksingh23, are you available to undertake this task, or should it be reassigned?

I am working on it.

@rishiraj38
Copy link
Copy Markdown
Member

@kanishksingh23 Please open a new PR for this.

Signed-off-by: kanishksingh23 <kanishksingh763@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sistent] Add Table component to the Sistent components page

4 participants