Skip to content

fix(icon): forward fill prop to path elements in ExternalLink and Dow… #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PARTH-TUSSLE wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(icon): forward fill prop to path elements in ExternalLink and Dow… #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64f501f
fix(icon): forward fill prop to path elements in ExternalLink and Dow…
PARTH-TUSSLE Jul 1, 2026
45925f7
Apply {...props} to the <svg> tag.
PARTH-TUSSLE Jul 1, 2026
4320634
Merge branch 'master' into fix/external-link-download-icon-fill
saurabhraghuvanshii Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions src/icons/Download/Download.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
import { FC } from 'react';
import { DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { DEFAULT_FILL_NONE, DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { IconProps } from '../types';

export const DownloadIcon: FC<IconProps> = ({
width = DEFAULT_WIDTH,
height = DEFAULT_HEIGHT,
fill = '#455a64',
style = {}
fill = DEFAULT_FILL_NONE,
...props
}) => (
<svg
xmlns="http://www.w3.org/2000/svg"
height={height}
viewBox="0 -960 960 960"
width={width}
fill={fill}
style={style}
{...props}
>
Comment thread
PARTH-TUSSLE marked this conversation as resolved.
<path d="M480-320 280-520l56-58 104 104v-326h80v326l104-104 56 58-200 200ZM240-160q-33 0-56.5-23.5T160-240v-120h80v120h480v-120h80v120q0 33-23.5 56.5T720-160H240Z" />
<path
d="M480-320 280-520l56-58 104 104v-326h80v326l104-104 56 58-200 200ZM240-160q-33 0-56.5-23.5T160-240v-120h80v120h480v-120h80v120q0 33-23.5 56.5T720-160H240Z"
fill={fill}
/>
</svg>
);

Expand Down
8 changes: 6 additions & 2 deletions src/icons/ExternalLink/Externallink.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import { FC } from 'react';
import { DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { DEFAULT_FILL_NONE, DEFAULT_HEIGHT, DEFAULT_WIDTH } from '../../constants/constants';
import { IconProps } from '../types';

export const ExternalLinkIcon: FC<IconProps> = ({
width = DEFAULT_WIDTH,
height = DEFAULT_HEIGHT,
fill = DEFAULT_FILL_NONE,
...props
}) => {
return (
Expand All @@ -15,7 +16,10 @@ export const ExternalLinkIcon: FC<IconProps> = ({
viewBox="0 -960 960 960"
{...props}
>
<path d="M200-120q-33 0-56.5-23.5T120-200v-560q0-33 23.5-56.5T200-840h280v80H200v560h560v-280h80v280q0 33-23.5 56.5T760-120H200Zm188-212-56-56 372-372H560v-80h280v280h-80v-144L388-332Z" />
<path
d="M200-120q-33 0-56.5-23.5T120-200v-560q0-33 23.5-56.5T200-840h280v80H200v560h560v-280h80v280q0 33-23.5 56.5T760-120H200Zm188-212-56-56 372-372H560v-80h280v280h-80v-144L388-332Z"
fill={fill}
/>
</svg>
);
};
Expand Down
Loading