Add: ShieldIcon#1690
Conversation
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new ShieldIcon component and exports it. The reviewer pointed out that using an empty object literal as a default value for the style prop is a React anti-pattern because it creates a new object reference on every render, which can trigger unnecessary re-renders. They suggested removing the default value assignment.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Lee Calcote <leecalcote@gmail.com>
| import { | ||
| DEFAULT_HEIGHT, | ||
| DEFAULT_WIDTH, | ||
| DEFAULT_FILL |
There was a problem hiding this comment.
We don't have other props? Where is the secondary color, @KhushamBansal?
|
Do the whole job, @KhushamBansal |
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
|
@leecalcote I have updated the PR. Now, the icon looks like this. 
|
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
Looks good to me. One question, though: in MUI and Meshery Cloud we refer to this as SecurityIcon, while in Sistent it's named Shield. Since this is being introduced in Sistent and isn't used anywhere yet, nothing should break. I'm just wondering about the naming conventions: should we align it with SecurityIcon, or is Shield the preferred name?
@rishiraj38 Thanks for pointing this out. I too think we should follow same naming as used in meshery-cloud. I'll make the change. |
Signed-off-by: KhushamBansal <kbkhushambansal@gmail.com>
|
Thank you for treating Cloud as the source of truth. |
4 participants
Notes for Reviewers
This PR fixes #1685
Signed commits