feat: product of Coxeter matrices#37160
feat: product of Coxeter matrices#37160vihdzp wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
PR summary fb131a4c00Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
| theorem reindex_apply (i i' : B') : M.reindex e i i' = M (e.symm i) (e.symm i') := rfl | ||
|
|
||
| /-- The Coxeter matrix `A * B` is the block matrix `!![A, 2; 2, B]`. -/ | ||
| instance : HMul (CoxeterMatrix B) (CoxeterMatrix B') (CoxeterMatrix (B ⊕ B')) where |
There was a problem hiding this comment.
Yeah, maybe this should just be a def with API instead?
There was a problem hiding this comment.
a) What should I call this?
b) What API should I put on this? This is mostly intended as a way to prove products of Coxeter groups are Coxeter, should I hold off on adding it before I prove that theorem?
There was a problem hiding this comment.
Yeah, maybe wait until we have that to look at.
|
This pull request is now in draft mode. No active bors state needed cleanup. While this PR remains draft, bors will ignore commands on this PR. Mark it ready for review before using commands like |
The Coxeter matrix
A * Bis the block matrix!![A, 2; 2, B].I've used multiplication to denote this under the logic that the product of Coxeter groups has a Coxeter matrix given by this construction. Perhaps this isn't desirable, considering it doesn't match matrix multiplication. I'm open to suggestions.