Skip to content

[Merged by Bors] - chore(GroupTheory/ResiduallyFinite): to_additivize some theorems#37174

Closed
tb65536 wants to merge 1 commit intoleanprover-community:masterfrom
tb65536:tb_toadd
Closed

[Merged by Bors] - chore(GroupTheory/ResiduallyFinite): to_additivize some theorems#37174
tb65536 wants to merge 1 commit intoleanprover-community:masterfrom
tb65536:tb_toadd

Conversation

@tb65536
Copy link
Copy Markdown
Contributor

@tb65536 tb65536 commented Mar 25, 2026

This PR to_additivize's some theorems in GroupTheory/ResiduallyFinite.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-group-theory Group theory labels Mar 25, 2026
@github-actions
Copy link
Copy Markdown

PR summary 36653f0972

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ _root_.AddSubgroup.finiteIndex_toSubgroup_iff
+ finiteIndex_toAddSubgroup_iff
+ instance _root_.AddSubgroup.finiteIndex_normalCore {G : Type*} [AddGroup G] (H : AddSubgroup G)

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Mar 25, 2026
Copy link
Copy Markdown
Contributor

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors merge

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Mar 26, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Mar 26, 2026
)

This PR to_additivize's some theorems in `GroupTheory/ResiduallyFinite`.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Mar 26, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title chore(GroupTheory/ResiduallyFinite): to_additivize some theorems [Merged by Bors] - chore(GroupTheory/ResiduallyFinite): to_additivize some theorems Mar 26, 2026
@mathlib-bors mathlib-bors Bot closed this Mar 26, 2026
justus-springer pushed a commit to justus-springer/mathlib4 that referenced this pull request Mar 28, 2026
…nprover-community#37174)

This PR to_additivize's some theorems in `GroupTheory/ResiduallyFinite`.

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc) t-group-theory Group theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants