[Merged by Bors] - feat(AlgebraicTopology/SimplicialSet/Subcomplex): add Subcomplex.unionProd, a union of products of subcomplexes#37182
Closed
mckoen wants to merge 5 commits intoleanprover-community:masterfrom
Closed
Conversation
mckoen
added
awaiting-CI
PR summary 15edd7a465
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.AlgebraicTopology.SimplicialSet.Monoidal | 952 | 964 | +12 (+1.26%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.AlgebraicTopology.SimplicialSet.Presentable |
7 |
Mathlib.AlgebraicTopology.Quasicategory.StrictBicategory |
9 |
Mathlib.AlgebraicTopology.SimplicialSet.NerveAdjunction Mathlib.CategoryTheory.Category.Cat.Colimit |
10 |
10 filesMathlib.AlgebraicTopology.SimplicialCategory.Basic Mathlib.AlgebraicTopology.SimplicialCategory.SimplicialObject Mathlib.AlgebraicTopology.SimplicialNerve Mathlib.AlgebraicTopology.SimplicialSet.FiniteProd Mathlib.AlgebraicTopology.SimplicialSet.HoFunctorMonoidal Mathlib.AlgebraicTopology.SimplicialSet.HomotopyCat Mathlib.AlgebraicTopology.SimplicialSet.KanComplex.MulStruct Mathlib.AlgebraicTopology.SimplicialSet.Monoidal Mathlib.AlgebraicTopology.SimplicialSet.ProdStdSimplex Mathlib.AlgebraicTopology.SimplicialSet.RelativeMorphism |
12 |
Declarations diff
+ bicartSq
+ image_β_hom
+ image_β_inv
+ isPushout
+ mem_unionProd_iff
+ preimage_image_of_isIso
+ preimage_β_hom
+ preimage_β_inv
+ prodIso
+ prod_le_prod_top
+ prod_le_top_prod
+ prod_le_unionProd
+ prod_top_le_unionProd
+ symmIso
+ top_prod_le_unionProd
+ unionProd
+ ι₁
+ ι₁_ι
+ ι₂
+ ι₂_ι
You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
github-actions
Bot
added
t-algebraic-topology
2 tasks
dagurtomas
reviewed
Mar 26, 2026
Contributor
dagurtomas
left a comment
dagurtomas
left a comment
There was a problem hiding this comment.
Thanks!
maintainer delegate
|
🚀 Pull request has been placed on the maintainer queue by dagurtomas. |
mathlib-triage
Bot
added
the
maintainer-merge
Co-authored-by: Dagur Asgeirsson <dagurtomas@gmail.com>
Member
|
Thanks! bors merge |
mathlib-triage
Bot
added
ready-to-merge
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Mar 27, 2026
…onProd`, a union of products of subcomplexes (#37182) Given `X Y : SSet`, `S : X.Subcomplex`, and `T : Y.Subcomplex`, define the subcomplex `S.unionProd T : (X ⊗ Y).Subcomplex` given by `(X ⊗ T) ⊔ (S ⊗ Y)` and provide basic API. All code is originally written by Joël Riou and modified for PR to mathlib (with permission).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
Subcomplex.unionProd, a union of products of subcomplexesSubcomplex.unionProd, a union of products of subcomplexes
justus-springer
pushed a commit
to justus-springer/mathlib4
that referenced
this pull request
Mar 28, 2026
…onProd`, a union of products of subcomplexes (leanprover-community#37182) Given `X Y : SSet`, `S : X.Subcomplex`, and `T : Y.Subcomplex`, define the subcomplex `S.unionProd T : (X ⊗ Y).Subcomplex` given by `(X ⊗ T) ⊔ (S ⊗ Y)` and provide basic API. All code is originally written by Joël Riou and modified for PR to mathlib (with permission).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given
X Y : SSet,S : X.Subcomplex, andT : Y.Subcomplex, define the subcomplexS.unionProd T : (X ⊗ Y).Subcomplexgiven by(X ⊗ T) ⊔ (S ⊗ Y)and provide basic API.All code is originally written by Joël Riou and modified for PR to mathlib (with permission).