Skip to content

chore(RingTheory/IntegralClosure/Algebra/Basic): generalize isIntegral_natCast and isIntegral_intCast#41746

Open
tb65536 wants to merge 1 commit into
leanprover-community:masterfrom
tb65536:tb_ncast
Open

chore(RingTheory/IntegralClosure/Algebra/Basic): generalize isIntegral_natCast and isIntegral_intCast#41746
tb65536 wants to merge 1 commit into
leanprover-community:masterfrom
tb65536:tb_ncast

Conversation

@tb65536

@tb65536 tb65536 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This PR generalizes isIntegral_natCast and isIntegral_intCast to be over an arbitrary base ring. I also renamed the IsAlgebraic lemmas to match.


Open in Gitpod

@tb65536 tb65536 added awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Jul 14, 2026
@tb65536 tb65536 requested a review from b-mehta July 14, 2026 17:35
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR summary 98e54ce359

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ isAlgebraic_intCast
+ isAlgebraic_natCast
+ isAlgebraic_ratCast

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 98e54ce).

  • +3 new declarations
  • −0 removed declarations
+isAlgebraic_intCast
+isAlgebraic_natCast
+isAlgebraic_ratCast

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 98e54ce359
Reference commit 783ccda4ee

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@b-mehta b-mehta added the auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. label Jul 14, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jul 14, 2026
@mathlib-auto-merge

Copy link
Copy Markdown

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

@mathlib-bors mathlib-bors Bot added the ready-to-merge This PR has been sent to bors. label Jul 14, 2026
@mathlib-bors

mathlib-bors Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Merge conflict.

Merge or rebase master into this PR and resolve the conflict, then someone with permission can run bors r+ or bors retry.

@mathlib-bors mathlib-bors Bot added awaiting-requeue This PR was on the bors queue but came off after a build failure or other issue. and removed ready-to-merge This PR has been sent to bors. labels Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. awaiting-requeue This PR was on the bors queue but came off after a build failure or other issue. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants