Skip to content

perf(LinearAlgebra/RootSystem/GeckConstruction/Semisimple):replace generic search with a more exp proof#41756

Open
FawadHa1der wants to merge 2 commits into
leanprover-community:masterfrom
FawadHa1der:perf-semisimple-aesop
Open

perf(LinearAlgebra/RootSystem/GeckConstruction/Semisimple):replace generic search with a more exp proof#41756
FawadHa1der wants to merge 2 commits into
leanprover-community:masterfrom
FawadHa1der:perf-semisimple-aesop

Conversation

@FawadHa1der

Copy link
Copy Markdown

generic search replaced by simplification and case splitting. Improves the local heartbeat/performance of the file. Does not affect the overall build.

Hopefully bench could show some numbers.

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 14, 2026
@github-actions

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@FawadHa1der

Copy link
Copy Markdown
Author

!bench

@leanprover-radar

leanprover-radar commented Jul 14, 2026

Copy link
Copy Markdown

Benchmark results for ec8668d against 056733e are in. There are significant results. @FawadHa1der

  • build//instructions: -72.9G (-0.05%)

Large changes (1✅)

  • build/module/Mathlib.LinearAlgebra.RootSystem.GeckConstruction.Semisimple//instructions: -92.2G (-41.88%)

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

PR summary 658d0dd1fc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 658d0dd).

  • +0 new declarations
  • −0 removed declarations

No declaration differences.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 658d0dd1fc
Reference commit 056733e1c3

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Jul 14, 2026
Comment on lines +214 to +216
ext i j
simp [Pi.single_apply]
split_ifs <;> simp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ext i j
simp [Pi.single_apply]
split_ifs <;> simp
ext i j
simp [Pi.single_apply]
split_ifs <;> simp

Indendation. Great PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants