-
Notifications
You must be signed in to change notification settings - Fork 142
feat: more lemmas on Euclidean relations #574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chenson2018
wants to merge
20
commits into
main
Choose a base branch
from
chenson2018/more-euclidean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+235
−6
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a50ccd5
{left,right}Total_equiv
chenson2018 7bac1f4
fintype_trichotomous_antisymm_card
chenson2018 e62c956
move apart fintype and finite
chenson2018 7d27d48
cod rename, subset theorems
chenson2018 717d19b
better proofs
chenson2018 4dfc1b0
don't duplicate Relator.LeftTotal
chenson2018 fb43aaa
Std.Trichotomous.{dom,cod}_eq
chenson2018 3d0a816
dom and cod
chenson2018 0e2da09
use complement
chenson2018 0daab44
equiv_{dom,cod}
chenson2018 b83f4e0
leftEuclidean_rightEuclidean_iff_dom_cod
chenson2018 69773f5
{left,right}Unique_trans
chenson2018 cf58fe4
total unique trans
chenson2018 2a9bd53
reference
chenson2018 16602f0
primed refl theorems
chenson2018 c9babf4
small golf
chenson2018 fac69ed
whitespace
chenson2018 24f1e8a
rm accidentally commited WIP
chenson2018 f6a8226
useless <|
chenson2018 70ff630
allow hetero for dom/cod
chenson2018 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we can defined something like:
Then the
codversions of many of these theorems can be derived from theirdomversions plus properties ofRelInv.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If taking this approach, I would have used the existing
fliporFunction.swap. They cause some problems that I attribute to there being a mismatch between core and Mathlib API. (Though maybe there's something more technical I've missed.) In a recent poll this form had more support, so I've tried to standardize on this approach, though I agree it is a bit ugly looking.