feat(algorithms): add stable bubble sort#575
Open
Robertboy18 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a stable bubble sort implementation for Lean lists (with comparison-counting in TimeM) and a shared stability predicate used to state/prove stability.
Changes:
- Introduces
StableByValueas a reusable stability predicate for list sorts. - Adds
bubbleSort(stable) returningTimeM ℕ (List α), plus correctness + time complexity theorems. - Exposes the new modules via
Cslib.leanimports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Cslib/Algorithms/Lean/Sorting.lean | Adds a stability predicate (StableByValue) intended for stable-sort proofs. |
| Cslib/Algorithms/Lean/BubbleSort/BubbleSort.lean | Implements stable bubble sort in TimeM with proofs (perm/stable/sorted) and a cost bound. |
| Cslib.lean | Re-exports the new sorting utilities and bubble sort module at the library root. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the stable bubble sort! The algorithm works in the usual way: each pass bubbles one maximal element to the end, then recursively sorts the remaining prefix. The stability proof follows the implementation pretty directly. We only swap when the next element is strictly smaller, so equal elements are never exchanged and keep their original order.
The PR proves that
bubbleSortreturns a sorted permutation of the input, preserves equal-value order viaStableByValue, and runs within a quadratic comparison bound.Validation:
lake build Cslib