feat(algorithms): add stable insertion sort#576
Open
Robertboy18 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds foundational sorting utilities and a timed, stable insertion sort implementation in Lean, including correctness and time-complexity proofs, and re-exports them from the top-level module.
Changes:
- Introduces a
StableByValuepredicate for expressing stability via per-value filtering. - Implements
TimeM-based insertion sort with comparison-counting, plus correctness/stability/sortedness proofs. - Exposes the new modules via
Cslib.leanimports.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Cslib/Algorithms/Lean/Sorting.lean | Adds StableByValue stability predicate used by sorting proofs. |
| Cslib/Algorithms/Lean/InsertionSort/InsertionSort.lean | Implements timed stable insertion sort with proofs and a time bound. |
| Cslib.lean | Re-exports the new sorting and insertion sort modules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds stable insertion sort! The implementation recursively sorts the tail and then inserts the head into the sorted result. The stability argument is the standard one: because the list is processed from right to left, inserting the current element before equal elements in the already-sorted tail preserves the original order of equal values. Standard insertion sort algorithm from CRLS.
I prove that it satisfies the sortedness, permutation correctness, stability via
StableByValue, and a quadratic comparison bound!Validation:
lake build Cslib