feat(FullBeta, FullEta): generalize step_not_fv#579
Conversation
|
Small changes like this can seem self-explanatory, but you have opened multiple PRs in a short span with no description. It would be appreciated to add appropriate descriptions, as they can be very helpful down the line. |
chenson2018
left a comment
There was a problem hiding this comment.
I appreciate the effort to keep these PRs small, but could you consolidate this and #578 into one PR? They seem to be the same idea that writing the subset is preferred direction of Finset.subset_iff_notMem. I'd grep for ∉ in this directory and see if there are any others.
|
Should we rename the lemma: |
Yes, but let's do the naming in a follow up PR to keep the diff clean. In general when I wrote this, I didn't follow the naming conventions well. |
|
Should I squash 2 commits to 1 ? |
|
Do we need to make the names the same on both sides? Idea: |
It does not matter, as we have this repo configured to squash all commits upon merging. |
|
What else do I need to do in this PR? |
What I would like is to merge in changes from your other PRs, then similarly update all other theorems where |
The PR prefer left side of
Finset.subset_iff_notMemFullBeta.step_not_fvmore powerful and reusable,N.fv ⊆ M.fvinstead ofw ∉ M.fv -> w ∉ N.fvFullEta.step_not_fvmore accurate: fv never changes after FullEta