Skip to content

feat(FullBeta, FullEta): generalize step_not_fv#579

Open
lengyijun wants to merge 2 commits into
leanprover:mainfrom
lengyijun:beta_subset
Open

feat(FullBeta, FullEta): generalize step_not_fv#579
lengyijun wants to merge 2 commits into
leanprover:mainfrom
lengyijun:beta_subset

Conversation

@lengyijun
Copy link
Copy Markdown
Contributor

@lengyijun lengyijun commented May 20, 2026

The PR prefer left side of Finset.subset_iff_notMem

  1. Make the FullBeta.step_not_fv more powerful and reusable, N.fv ⊆ M.fv instead of w ∉ M.fv -> w ∉ N.fv
  2. Make the FullEta.step_not_fv more accurate: fv never changes after FullEta

@lengyijun lengyijun requested a review from chenson2018 as a code owner May 20, 2026 00:30
@chenson2018
Copy link
Copy Markdown
Collaborator

Small changes like this can seem self-explanatory, but you have opened multiple PRs in a short span with no description. It would be appreciated to add appropriate descriptions, as they can be very helpful down the line.

Copy link
Copy Markdown
Collaborator

@chenson2018 chenson2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort to keep these PRs small, but could you consolidate this and #578 into one PR? They seem to be the same idea that writing the subset is preferred direction of Finset.subset_iff_notMem. I'd grep for in this directory and see if there are any others.

@lengyijun
Copy link
Copy Markdown
Contributor Author

Should we rename the lemma: step_not_fv looks on longer suitable

@chenson2018
Copy link
Copy Markdown
Collaborator

Should we rename the lemma: step_not_fv looks on longer suitable

Yes, but let's do the naming in a follow up PR to keep the diff clean. In general when I wrote this, I didn't follow the naming conventions well.

@lengyijun lengyijun changed the title feat(FullBeta): generalize step_not_fv feat(FullBeta, FullEta): generalize step_not_fv May 20, 2026
@lengyijun
Copy link
Copy Markdown
Contributor Author

Should I squash 2 commits to 1 ?

@lengyijun
Copy link
Copy Markdown
Contributor Author

lengyijun commented May 20, 2026

Do we need to make the names the same on both sides?

Idea:

lemma step_fv_eq (step : M ⭢ηᶠ M') : M.fv = M'.fv := by

lemma step_fv_subset (step : M ⭢βᶠ N) : N.fv ⊆ M.fv := by

@lengyijun lengyijun requested a review from chenson2018 May 20, 2026 05:13
@chenson2018
Copy link
Copy Markdown
Collaborator

Should I squash 2 commits to 1 ?

It does not matter, as we have this repo configured to squash all commits upon merging.

@lengyijun
Copy link
Copy Markdown
Contributor Author

What else do I need to do in this PR?

@chenson2018
Copy link
Copy Markdown
Collaborator

What else do I need to do in this PR?

What I would like is to merge in changes from your other PRs, then similarly update all other theorems where x ∉ ?_ appears in a hypothesis and the goal. As you already noted, some grind proofs will need to be adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants