fix: recognize opaque constants of unit-like types as definitionally equal - #14550
Open
kernelpanic888 wants to merge 2 commits into
Open
fix: recognize opaque constants of unit-like types as definitionally equal#14550kernelpanic888 wants to merge 2 commits into
kernelpanic888 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows
rflto prove equality between distinct opaque constants whose common type is unit-like, fixing #14348.The definitional equality checker now falls back to its existing unit-like check only when two constant names differ, preserving the fast path for identical constants. A regression test covers two opaque
Unitconstants.Tested with a clean stage1 build and
tests/with_stage1_test_env.sh tests/elab/run_test.sh 14348.lean.AI assistance was used to locate the diagnosed control-flow branch and draft the minimal patch and regression test. I manually reviewed the change and verified the clean build and focused test.