[19.0][MIG] web_leaflet_lib + web_leaflet_draw_lib: Migration to 19.0#1
Open
dnplkndll wants to merge 4 commits into
Open
[19.0][MIG] web_leaflet_lib + web_leaflet_draw_lib: Migration to 19.0#1dnplkndll wants to merge 4 commits into
dnplkndll wants to merge 4 commits into
Conversation
dnplkndll
changed the title
This was referenced May 17, 2026
The handle had a trailing apostrophe ("NL66278'") inherited from
the 18.0 manifest. Fixing while we touch the manifest so OCA's bot
maintainer-tagging machinery resolves the real GitHub handle.
dnplkndll
force-pushed
the
19.0-mig-web_leaflet_lib
branch
from
5a603c8 to
8dbbb0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates both
web_leaflet_lib(the base Leaflet JS wrapper) andweb_leaflet_draw_lib(the Leaflet.draw editing toolkit on top) from 18.0 to 19.0. Bundled together becauseweb_leaflet_draw_libdepends onweb_leaflet_liband OCA's CI rejects unreleased deps — separating into two PRs would leave the draw_lib PR red until the lib PR merges, and both modules are tiny JS-asset wrappers (manifest version bumps only, no Python/XML changes).What changed per module
web_leaflet_lib(commit178b97d)18.0.1.1.0→19.0.1.0.0models/ir_http.py(session_info()super call),hooks.py(post_init_hook(env)),data/ir_config_parameter.xml, and the assets globs all work unchanged in 19.0web_leaflet_draw_lib(commitd96b297)18.0.1.0.0→19.0.1.0.0Why on the ledoent fork (not OCA upstream)
OCA/geospatial 19.0 is mostly empty — only
base_geoenginehas an upstream MIG PR (OCA#446). We need these JS libs to unblockfarm_field_geo's in-form polygon editing in the farm-pack, so we migrate on our fork first and pin via workspacerepos.yaml. Upstream PR follows once install-validated locally.What it unblocks
farm_field_geo(ledoent/farm-pack PR base_geoengine_demo: javascript errors OCA/geospatial#2) — thegeo_edit_mapwidget's vertex-drag UX comes from Leaflet-Geoman (shipped here asleaflet.draw.js)web_view_leaflet_map,web_view_leaflet_map_partner)Test plan
base_geoenginePR [19.0][MIG] base_geoengine: migrate to 19.0 OCA/geospatial#446 + this PR) is pinned in industry-packsrepos.yamlbase_geoengineGeoPolygon field renders with Leaflet-Geoman draw controls (edit vertex, delete polygon, draw new)Follow-up
Once base_geoengine PR OCA#446 merges upstream we can build a clean dependency chain and upstream this combined MIG to OCA/geospatial as well.