feat: (fix?) try known prefixes to find correspondance for applying imatrix#1737
Open
stduhpf wants to merge 1 commit into
Open
feat: (fix?) try known prefixes to find correspondance for applying imatrix#1737stduhpf wants to merge 1 commit into
stduhpf wants to merge 1 commit into
Conversation
stduhpf
changed the title
leejet
requested changes
Jul 5, 2026
| } | ||
| std::string processed_name = convert_tensor_name(tensor_storage.name, imatrix_version); | ||
| std::vector<float> imatrix = get_imatrix_collector().get_values(processed_name); | ||
| if (imatrix.empty()) { |
Owner
There was a problem hiding this comment.
I think it would be better to pass in a --imat-prefix argument to specify the prefix, rather than trying to hardcode the traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows to apply imatrix to model parts without creating an all in one checkpoint.
Related Issue / Discussion
Additional Information
Checklist