Skip to content

templating#4

Merged
gmanchon merged 13 commits into
masterfrom
build-templating
Jun 3, 2026
Merged

templating#4
gmanchon merged 13 commits into
masterfrom
build-templating

Conversation

@gmanchon

@gmanchon gmanchon commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

adds liquid templating

replaces partials substituted constants <PYTHON_VERSION> with variables {{ PYTHON_VERSION }}

replaces partials delimiter-structured blocks :

$MAC_START
  ...
$MAC_END
$WINDOWS_START
  ...
$WINDOWS_END
$LINUX_START
  ...
$LINUX_END

with conditionals :

{% if os == "macos" %}
  ...
{% elsif os == "windows" %}
  ...
{% elsif os == "linux" %}
  ...
{% endif %}

no diffs in generated localised build files appart from blank lines

specific repo diffs

replicates lewagon/data-setup#361

adds the build gha that was missing

removes the ES readme since the ES partials exist but the per-build ES markdown files do not

the checks now point to resources on this repo (curl -fsSL https://raw.githubusercontent.com/lewagon/data-analytics-setup/master/checks/pip_check.py)"

diffs in content are caused by missing updates since the build gha was missing

@gmanchon gmanchon requested a review from beamishc June 2, 2026 15:51
@gmanchon

gmanchon commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

Hello @beamishc 👋

I updated the build gha from the one of the DS setup in order to support liquid templating and simplify the edition of the _partials instructions

The main differences in the code structure are :

  • the variables available to all partials, as {{ PYTHON_VERSION }}, are stored in constants/constants.yml
  • the formulas are now stored in builds in yaml format, for example builds/LINUX.yml
  • it will soon be possible to parametrise a partial in order to adapt its content to the setup it is called from

I already merged the DS and DE setups because I need to iterate on the remote setup instructions for B2B bootcamps with VMs provided by LW

In theory the change should not have updated the instructions but I notice the build gha was missing from this repo so the rerun updated the instructions according to the latest content of the partials of all setup repos

The update of the gha did not produce any diffs in the DS and DE setups, and all changes seem correct and legit, but let me know what you think 🙏

Also I removed README.es.md since the corresponding instructions are missing, but happy to correct and add it back

ps : liquid does add tons of empty lines, but purists may mitigate the issue with proper use of {%- and -%}

@gmanchon gmanchon force-pushed the build-templating branch from dc14ba0 to bc3bae2 Compare June 3, 2026 13:55
@gmanchon gmanchon merged commit 09b10a2 into master Jun 3, 2026
@gmanchon gmanchon deleted the build-templating branch June 3, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant