📝 CodeRabbit Chat: Implement requested code changes#388
📝 CodeRabbit Chat: Implement requested code changes#388coderabbitai[bot] wants to merge 4 commits into
Conversation
Introduce an `EnvProvider` port for CLI configuration resolution. Thread it through explicit config selection, diagnostic layer collection, and early diagnostic JSON resolution so tests can use deterministic environment doubles instead of process-wide mutation. Reject malformed `NETSUKE_DIAG_JSON` values with a validation error, and keep discovery load errors visible while resolving startup diagnostic mode.
Drop provider-free compatibility wrappers that became dead code after the rebase onto the split `discovery` and `diag` modules. Keep the injected provider helpers as the single internal path for config selection and early JSON diagnostic resolution. Update the related internal docs and test helper so the branch stays clean under warnings-denied typechecking and Clippy.
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @coderabbitai[bot], you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
lodyai
Bot
force-pushed
the
issue-293-refactor-collect-diag-file-layers
branch
from
273e983 to
678929e
Compare
1 participant
Code changes was requested by @leynos.
The following files were modified:
src/main.rs