proof: bridge add expression helper constructor#2109
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d4f689e8-d0b4-44ef-9694-9570c7273ab1) |
|
Stack repair status for #2080:
Local validation completed:
Merge blocker: CI is not complete yet for this PR. Run https://github.com/lfglabs-dev/verity/actions/runs/28773176893 has |
|
Review/merge re-check for #2109: Diff review and local validation are clean:
Merge blocker: GitHub CI is still incomplete and the PR merge state is
|
|
Review/merge follow-up for #2109 after a bounded 45-minute CI wait: GitHub review threads are still empty, and Cursor Bugbot still only has the usage-limit skip. The PR head remains Merge blocker: GitHub CI is still incomplete and the PR merge state remains
All previously queued |
Restores the unique phase work from closed-unmerged #2103 after #2102 merged and the old base branch was deleted.
Summary
Expr.addsource, compile, and Yul builtin value facts for helper-aware expression proofsexprInternalHelperCompositionalContextResult_add_right_threaded, a non-vacuous right-child bridge that uses the threaded binary API after the left operand advances the IR statePrintAxioms.leanReferences #2080.
Supersedes closed #2103. This branch was rebased onto
mainand drops the duplicate #2101/#2102 commits now already merged.Validation
lean-slot lake build Compiler.Proofs.HelperStepProofspassed on head8a973ce1.python3 scripts/generate_print_axioms.py --checkpassed.python3 scripts/check_proof_length.pypassed.git diff --check origin/main...HEADpassed.rg -n "\\bsorry\\b|\\badmit\\b|\\baxiom\\b" Compiler/Proofs/HelperStepProofs.leanfound no matches.Note
Low Risk
Proof-only additions in HelperStepProofs with no changes to compilation or runtime semantics; axiom inventory is regenerated for tracking.
Overview
Adds constructor-specific Lean proofs for
Expr.addin the helper-aware expression compositional pipeline: sharedexprAddValue, compile/source/Yul-builtin value lemmas, and auint256_ofNatEVM-modulus normalization lemma used to align source semantics withUint256addition.Introduces
exprInternalHelperCompositionalContextResult_add_right_threaded, the first non-internalCallexpression constructor that fully discharges compile, source, and IR facts via the threaded binary API (left operand advances IR state; right child carries helper payload from the updated state).Regenerates
PrintAxioms.leanto register the five new public theorems (+5 in the inventory count).Reviewed by Cursor Bugbot for commit 8a973ce. Bugbot is set up for automated code reviews on this repo. Configure here.