proof: bridge function internals body compile#2115
Open
Th0rgal wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_3d40ca88-6b75-43be-87f4-ca206c2777c2) |
Member
Author
|
Review/validation update from Codex fallback merge gate:
Not merging. Exact blocker: stack policy/base dependency. #2115 is stacked on #2114, and the predecessor stack #2111, #2112, #2113, and #2114 is still open. Per the PR body and merge policy, #2115 must wait until the required predecessor stack is merged/green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base / dependency
Stacked on #2114 (
paloma/issue-2080-helper-ir-withinternals), which is still open/mergeable/green. Do not merge until predecessor stack is merged/green.Summary
compileFunctionSpecshape bridge that preserves caller-provided ADT/internal-helper environments through to the bodycompileStmtListfact.model.functionsbody compile fact from helper-aware function compilation and threads the splitWithInternalsbody consumer into the function proof path.PrintAxioms.leanand add a proof-length allowlist entry for the interface-heavy bridge after factoring the state/binding plumbing into private helpers.Validation
lean-slot lake build Compiler.Proofs.IRGeneration.FunctionShape Compiler.Proofs.IRGeneration.Functionpassed.lean-slot lake build Compiler.Proofs.IRGeneration.Functionpassed after decomposition.lean-slot lake build Compiler.Proofs.HelperStepProofspassed.lean-slot lake build Compiler.Proofs.IRGeneration.Contractpassed.python3 scripts/generate_print_axioms.py --checkpassed.python3 scripts/check_proof_length.pypassed.git diff --checkpassed.sorry,admit, oraxiomin touched proof files.Refs #2080
Remaining #2080 gate
The full function-level retarget still needs the compiled-side
execIRFunctionWithInternalsparam-loading/function execution bridge, so whole-contract dispatch can consume the helper-rich function theorem without falling back through default-empty helper-world/conservative-extension wrappers.Note
Low Risk
Additive, machine-checked proof lemmas in IR generation only; no runtime or auth behavior changes.
Overview
Adds proof infrastructure for #2080 so function-level correctness can use helper-rich
compileFunctionSpecfacts instead of the legacy empty ADT/helper world.FunctionShape.compileFunctionSpec_ok_components_with_internalsmirrors the existingcompileFunctionSpec_ok_componentsdecomposition but threads calleradtTypesandinternalFunctionsthrough to the bodycompileStmtListsuccess fact.supported_function_body_with_internals_goal_of_compileFunctionSpec_with_internalsis the main entry: from a successful helper-aware compile plus the splitWithInternalsstep interfaces, it producesSupportedFunctionBodyWithHelpersAndHelperIRPreservationGoalwith param binding state already wired. Three private lemmas factor out scope names, runtime IR alignment, and binding equality frombindSupportedParams.PrintAxioms.leanandscripts/check_proof_length.pyare updated for the new public theorem and allowlist entry.Reviewed by Cursor Bugbot for commit 7e600a5. Bugbot is set up for automated code reviews on this repo. Configure here.