ci: authenticate OCR router base fetch#2136
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_2dee7db9-b396-49b0-ae25-866f3381d702) |
Member
Author
|
@codex review |
Contributor
|
No stderr captured. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Production context
Production /ocr review on #2128 and #2127 after #2133 merged failed in Route OCR review because the authenticated fetch prompted for GitHub credentials on the self-hosted runner. This PR fixes that production blocker.
Note
Low Risk
CI-only workflow changes for git auth and step gating; no application runtime or security-sensitive product code.
Overview
Fixes Route OCR review failing on self-hosted runners when
git fetchfor the PR base ref prompted for credentials (production blocker after #2133).The router step no longer relies on
git -c http.extraheader=...for auth. It briefly rewritesoriginto ax-access-tokenURL, fetchesBASE_REF, then restores the original remote (with anEXITtrap so cleanup still runs on failure).Post OCR review and Upload OCR metrics now require
steps.route.outcome == 'success', so a failed router does not publish a review or upload metrics when result/metrics JSON was never produced.Reviewed by Cursor Bugbot for commit 5041cee. Bugbot is set up for automated code reviews on this repo. Configure here.