proof: package legacy compatibility for mapping2word writes#2145
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_d01a3613-a3d4-4d4b-bdf7-664d4e742645) |
OpenCodeReview first-pass reviewStatus: completed_with_errors · Mode: medium-lean · 0 finding(s) · 2 files · 337963 tokens · 34 tool calls Some files could not be reviewed due to errors. Warnings
OCR pilot metrics
Pilot mode: advisory only. Codex Review remains the merge gate. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
CompilationModel.compileSetMapping2Wordover singleton ordinary two-key mapping word writes.StmtListCompiledLegacyCompatiblefor[Stmt.setMapping2Word ...].PrintAxioms.leanaudit entries/counts.Base / dependencies
paloma/issue-2080-mapping-chain-phase33(proof: package legacy compatibility for mapping-chain writes #2143), which is open, clean, and green at inspection time.Do not merge until predecessor stack is merged/green.
Validation
git diff --checkpassed.lean-slot lake build Compiler.Proofs.IRGeneration.Function Compiler.Proofs.IRGeneration.Contract PrintAxiomspassed.python3 scripts/generate_print_axioms.py --checkpassed:PrintAxioms.lean is up to date.python3 scripts/check_proof_length.pypassed:5811 proofs scanned, no new proofs exceed the 50-line hard limit.sorry,admit, oraxiomdeclarations in touched proof files;rghits were onlyPrintAxiomscomment/header text.Refs #2080
Note
Low Risk
Proof-only additions with no changes to compilation logic or runtime behavior; risk is limited to formal verification maintenance.
Overview
Extends the IR-generation legacy-compatibility story to
setMapping2Word(two-key mapping writes at a word offset), mirroring the existingsetMapping2packaging.Adds
compileSetMapping2Word_legacyCompatible, which case-splits on successfulcompileSetMapping2Wordoutput and shows the emitted Yul isLegacyCompatibleExternalStmtList, including nestedmappingSlotkeys and anaddwhenwordOffset ≠ 0, withsstore/tstorechosen from field transience. Adds publicstmtList_setMapping2WordSingle_compiledLegacyCompatibleso a singleton[Stmt.setMapping2Word …]list isStmtListCompiledLegacyCompatible.PrintAxioms.leanis refreshed to list the new private helper (commented) and public theorem, with theorem counts 5613 → 5615.Reviewed by Cursor Bugbot for commit 03892e9. Bugbot is set up for automated code reviews on this repo. Configure here.