fix(release): baseline preview changelogs from the prior stable - #1041
Merged
Conversation
The release-notes previous-tag was computed from \git tag --merged HEAD\, which hides stable tags on main's lineage from the preview branch. A trailing same-core preview (vX.Y.Z-preview.* shipped after vX.Y.Z) therefore became the newest prior tag, so 2.10.0-preview notes compared v2.9.1-preview...v2.10.0-preview instead of v2.9.1...v2.10.0-preview. The notes baseline now reads the full tag set (\git tag --list 'v[0-9]*'\); the helper's semver ordering already ranks the stable above its own trailing preview. The service-lifecycle changed-files gate keeps the merged-only baseline because it is deliberately lineage-relative. Regression tests lock the full-set contract in the workflow and the trailing-preview case in the helper.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe release workflow now uses all repository tags for release-note baseline selection, while the CI service gate still uses tags merged into ChangesRelease baseline selection
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Preview release changelogs compare against the previous preview instead of the prior stable:
v2.10.0-preview.20260802release notes showFull Changelog: …/compare/v2.9.1-preview.20260802...v2.10.0-preview.20260802…/compare/v2.9.1...v2.10.0-preview.20260802(the stable release already shows the correctv2.9.1...v2.10.0)Root cause
.github/workflows/release.ymlcomputed the notes previous tag fromgit tag --merged HEAD. Stable tags live onmain's lineage, which the preview branch does not carry (v2.9.1is not an ancestor ofv2.10.0-preview.20260802), sov2.9.1never entered the candidate list. The trailing same-core previewv2.9.1-preview.20260802(shipped 15s after the stable) became the newest prior tag. The helper's semver ordering was already correct — the tag source was the bug.Fix
git tag --list 'v[0-9]*'). The helper's semver ordering ranks the stable above its own trailing preview, so the range resolves tov2.9.1 → v2.10.0-preview.git tag --merged HEAD: that comparison is deliberately lineage-relative, and the comment now says why the two baselines differ.scripts/release-notes.tsdocuments the full-set contract onpreviousReleaseNotesTag.Verification
bun run typecheckgreen.bun test --isolate tests/release-notes.test.ts tests/ci-workflows.test.ts: 147 pass / 0 fail.generate-notes: previous tag resolves tov2.9.1, and the rendered notes carryFull Changelog: https://github.com/lidge-jun/opencodex/compare/v2.9.1...v2.10.0-preview.20260802with the identical PR list (feat(providers): add Baseten Model APIs preset #653, feat(server): advertise reasoning-effort ladders on the raw /v1/models list #853, fix(providers): keep Antigravity catalog static #744, docs(codex): clarify pool routing and account continuity #862) — nothing dropped or duplicated.v2.9.1...v2.10.0), and preview-after-preview incrementality (no stable in between) is preserved by the existing tests.Summary by CodeRabbit
Bug Fixes
Documentation
Tests