[codex] Add Modelsell provider preset - #562
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Please change the PR to ready for review once you are finished @modelsell |
|
Thank you for the implementation work here — the code itself is in good shape. The registry entry, docs, and localized copy are consistent, and I am closing this as not-ready rather than merging, because a canonical registry entry is a credential-destination change: opencodex would be shipping the endpoint that a user's API key is sent to. Reviewing against that bar, the following evidence is still missing.
To be explicit: this is not about who submitted it. Contributors adding their own service are welcome here, and existing presets arrived that way with an affiliation disclosure. Affiliation does not disqualify a preset and does not lower the evidence bar. Two paths forward, both open:
I have documented this bar in |
A registry entry ships the destination a user's API key is sent to, so it needs primary-source evidence rather than a passing fixture test. Write the bar down once, in the public contributing guide and the maintainer policy, so it applies uniformly to every provider PR. Required for a canonical preset: documented OpenAI-compatible endpoints (including authenticated GET /v1/models when the entry declares liveModels), terms of service and operating legal entity, resale/routing authorization for aggregators reselling third-party models, a named maintenance owner, and a citable verification date in the spirit of free-directory's lastVerified. Contributor affiliation with the service is disclosed, not disqualifying, and it does not lower the evidence bar — several current presets arrived that way. When evidence is incomplete, an inert free-directory.ts reference row is the honest home: users still reach the service through the custom OpenAI-compatible flow, without opencodex advertising a preset it cannot stand behind. Prompted by the review of #562 (Modelsell), closed as not-ready for missing endpoint, legal-entity, authorization, ownership, and verification evidence.
Summary
openai-chatadapterhttps://modelsell.com/v1endpoint and authenticated live model discoveryCloses #561.
Verification
bun run typecheckbun test tests/modelsell-provider.test.ts tests/provider-registry-parity.test.ts(34 passed)bun run lint:guibun run build:guibun run privacy:scangit diff --checkThe full
bun run prepushsuite was also attempted. It did not complete cleanly in this environment because unrelated existing child-process tests timed out and test-only hosts resolved to198.18.x, which triggered destination-policy blocks. The Modelsell-focused tests and checks above pass.Checklist