offer: add a test with expiry info#518
Closed
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
Closed
offer: add a test with expiry info#518vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
vincenzopalazzo wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the code in [1], an interesting issue was discussed related to the expiry of the offer.
The reported problem is as follows:
This commit adds a test to ensure that we can pay an offer with an expiry of 1 day without encountering an InvoiceRequestExpired error.
[1] getAlby/hub#1242
Signed-off-by: Vincenzo Palazzo vincenzopalazzodev@gmail.com