Skip to content

Async recipient-side of static invoice server #3618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 8 commits into from
Jun 27, 2025

Add API to retrieve a cached async receive offer

0608de1
Select commit
Loading
Failed to load commit list.
Merged

Async recipient-side of static invoice server #3618

Add API to retrieve a cached async receive offer
0608de1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 26, 2025 in 1s

89.55% (-0.10%) compared to 24063e5

View this Pull Request on Codecov

89.55% (-0.10%) compared to 24063e5

Details

Codecov Report

Attention: Patch coverage is 27.74566% with 125 lines in your changes missing coverage. Please review.

Project coverage is 89.55%. Comparing base (24063e5) to head (0608de1).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 19.11% 55 Missing ⚠️
lightning/src/onion_message/async_payments.rs 0.00% 29 Missing ⚠️
lightning/src/ln/peer_handler.rs 0.00% 20 Missing ⚠️
lightning/src/onion_message/functional_tests.rs 0.00% 20 Missing ⚠️
lightning/src/offers/async_receive_offer_cache.rs 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3618      +/-   ##
==========================================
- Coverage   89.65%   89.55%   -0.10%     
==========================================
  Files         164      165       +1     
  Lines      134658   134830     +172     
  Branches   134658   134830     +172     
==========================================
+ Hits       120723   120751      +28     
- Misses      11256    11395     +139     
- Partials     2679     2684       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov