Skip to content

#3618 followups + expose async receive feature #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 12 commits into from
Aug 13, 2025

Remove async payments cfg flag

c0b8a44
Select commit
Loading
Failed to load commit list.
Merged

#3618 followups + expose async receive feature #3999

Remove async payments cfg flag
c0b8a44
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 11, 2025 in 0s

88.84% (-0.09%) compared to de2005a

View this Pull Request on Codecov

88.84% (-0.09%) compared to de2005a

Details

Codecov Report

❌ Patch coverage is 86.82171% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.84%. Comparing base (de2005a) to head (c0b8a44).
⚠️ Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/async_payments_tests.rs 83.06% 20 Missing and 1 partial ⚠️
lightning/src/offers/async_receive_offer_cache.rs 85.36% 1 Missing and 5 partials ⚠️
lightning/src/ln/channelmanager.rs 86.20% 3 Missing and 1 partial ⚠️
lightning/src/offers/flow.rs 94.73% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3999      +/-   ##
==========================================
- Coverage   88.93%   88.84%   -0.09%     
==========================================
  Files         174      175       +1     
  Lines      124539   127634    +3095     
  Branches   124539   127634    +3095     
==========================================
+ Hits       110758   113402    +2644     
- Misses      11287    11678     +391     
- Partials     2494     2554      +60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov