Skip to content

Async send always-online counterparty side #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinewallace merged 11 commits into from
Sep 11, 2025

Add pending_changelog for async send

6aa52e9
Select commit
Loading
Failed to load commit list.
Merged

Async send always-online counterparty side #4045

Add pending_changelog for async send
6aa52e9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 10, 2025 in 0s

88.35% (-0.41%) compared to ecce859

View this Pull Request on Codecov

88.35% (-0.41%) compared to ecce859

Details

Codecov Report

❌ Patch coverage is 62.28814% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.35%. Comparing base (ecce859) to head (6aa52e9).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 58.33% 64 Missing and 6 partials ⚠️
lightning/src/offers/flow.rs 0.00% 17 Missing ⚠️
lightning/src/ln/channel.rs 96.87% 1 Missing ⚠️
lightning/src/util/ser_macros.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4045      +/-   ##
==========================================
- Coverage   88.76%   88.35%   -0.41%     
==========================================
  Files         176      177       +1     
  Lines      129518   131472    +1954     
  Branches   129518   131472    +1954     
==========================================
+ Hits       114968   116167    +1199     
- Misses      11945    12655     +710     
- Partials     2605     2650      +45

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov