Skip to content

Reconstruct ChannelManager forwarded HTLCs maps from Channels #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinewallace merged 9 commits into from
Dec 11, 2025

Test 0.2 -> 0.3 reload with with forward htlcs present

a24dcff
Select commit
Loading
Failed to load commit list.
Merged

Reconstruct ChannelManager forwarded HTLCs maps from Channels #4227

Test 0.2 -> 0.3 reload with with forward htlcs present
a24dcff
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 11, 2025 in 0s

89.37% (+0.03%) compared to de384ff

View this Pull Request on Codecov

89.37% (+0.03%) compared to de384ff

Details

Codecov Report

❌ Patch coverage is 75.00000% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.37%. Comparing base (de384ff) to head (a24dcff).
⚠️ Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channelmanager.rs 62.50% 46 Missing and 2 partials ⚠️
lightning/src/ln/channel.rs 80.00% 7 Missing and 2 partials ⚠️
lightning/src/ln/reload_tests.rs 98.30% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4227      +/-   ##
==========================================
+ Coverage   89.33%   89.37%   +0.03%     
==========================================
  Files         180      180              
  Lines      139042   139599     +557     
  Branches   139042   139599     +557     
==========================================
+ Hits       124219   124770     +551     
- Misses      12196    12240      +44     
+ Partials     2627     2589      -38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov