Skip to content

Refactor BroadcasterInterface to include TransactionType #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 3 commits into from
Feb 5, 2026

Drop unused imports

0715f4a
Select commit
Loading
Failed to load commit list.
Merged

Refactor BroadcasterInterface to include TransactionType #4353

Drop unused imports
0715f4a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 3, 2026 in 0s

85.99% (+0.01%) compared to 8679d8d

View this Pull Request on Codecov

85.99% (+0.01%) compared to 8679d8d

Details

Codecov Report

❌ Patch coverage is 84.09091% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.99%. Comparing base (8679d8d) to head (0715f4a).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/util/sweep.rs 79.59% 6 Missing and 4 partials ⚠️
lightning/src/ln/channelmanager.rs 72.72% 8 Missing and 1 partial ⚠️
lightning/src/ln/channel.rs 46.15% 6 Missing and 1 partial ⚠️
lightning-liquidity/src/lsps2/service.rs 85.71% 0 Missing and 1 partial ⚠️
lightning/src/chain/onchaintx.rs 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4353      +/-   ##
==========================================
+ Coverage   85.98%   85.99%   +0.01%     
==========================================
  Files         156      156              
  Lines      102641   102734      +93     
  Branches   102641   102734      +93     
==========================================
+ Hits        88258    88349      +91     
- Misses      11873    11875       +2     
  Partials     2510     2510

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov