Implemented CORS mechanism#2423
Draft
maifeeulasad wants to merge 9 commits into
Draft
Conversation
Co-authored-by: Copilot <copilot@github.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Co-authored-by: Copilot <copilot@github.com>
Author
|
When I ran the v8 in debug mode locally I had no issues. It passed. Here is the exact command. And regarding demo runner I am bit confused now! Care to guide me please? So that we can get this done! cc: @krichprollsch |
Member
|
@maifeeulasad no worries, we have flaky tests. I will re-start them, not a blocker for review. |
Author
|
@krichprollsch eagerly waiting for reviews and open for change requests. |
| } | ||
|
|
||
| /// Validate response headers for client-side CORS checks | ||
| pub fn isResponseAllowed( |
Member
There was a problem hiding this comment.
I may be wrong, but it seems only isReponseAllowed is used from Cors.zig, other functions are deadcode?
$ ag "Cors\." src/
src/browser/webapi/net/Fetch.zig
22:const Cors = @import("../../../network/Cors.zig");
211: if (!Cors.isResponseAllowed(allow_origin, allow_credentials, requesting_origin.?, self._allow_credentials)) {
src/browser/webapi/net/XMLHttpRequest.zig
25:const Cors = @import("../../../network/Cors.zig");
508: if (!Cors.isResponseAllowed(allow_origin, allow_credentials, request_origin.?, self._with_credentials)) {
Author
There was a problem hiding this comment.
Fixing this. Give me a week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2015