plan: unify card transactions under Incoming/Outgoing (prototype)#645
Draft
ls-bolt[bot] wants to merge 1 commit into
Draft
plan: unify card transactions under Incoming/Outgoing (prototype)#645ls-bolt[bot] wants to merge 1 commit into
ls-bolt[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Planning-phase draft for prototyping the removal of
CardTransactionas a thirdTransactionOneOfvariant, folding card activity into the existingIncomingTransaction/OutgoingTransactiontypes via the discriminatedsource/destinationunions (newCARDdestination for purchases, newCARDsource for standalone merchant credits). Fine-grained card lifecycle is preserved ascardStatuson the destination.Full plan:
docs/plans/2026-07-06-unify-card-transactions.md(rendered in the Files tab — inline comments welcome).On approval, this branch will be updated with the actual spec prototype and the plan file removed.
Reply with a comment (e.g. LGTM) to approve — emoji reactions don't notify me here.
Slack thread: https://lightsparkgroup.slack.com/archives/C0A28TVUZ4Z/p1783024275813329
🤖 blazing-photon-3(#3) | Feedback